Closed (fixed)
Project:
Workbench Moderation
Version:
7.x-2.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
13 Dec 2012 at 23:27 UTC
Updated:
4 Jan 2014 at 02:42 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
stevectorhttp://drupalcode.org/project/workbench_moderation.git/commit/b133015461...
Comment #3
stevectorThis change broke the tests for installing the default config. I think that functionality of "You don't have a workflow configured, would you like the default one?" should move to hook_requirements.
Comment #4
stevectorTagging for Workbench Sprint.
Comment #5
stevectorComment #6
hass commentedCan we postpone this after #1768584: Translatable string review has been committed as this may required a re-role of this translatable string review monster patch? This was really a lot of work.
Comment #7
kbentham commentedA patch that add the form to the status reports page, and fixed the tests appropriately.
Comment #8
stevectorhass, the translatable string patch is to moderation 1.x. This patch is to 2.x so there should be no conflict.
Comment #9
stevectorI'm getting this error when installing workbench_workflows with this patch
I'm confused because that function is in the module file.
I think what's happening here is that hook_requirements gets called even before the module is enabled. Check out the API page on hook_requirements. I think we need to check the value of $phase before running the rest of this code.
I'm also attaching a version of the patch that has some whitespace cleanup.
Comment #10
kbentham commentedI have added a condition to see if $phase is runtime.
Comment #11
stevectorThanks!
http://drupal.org/commitlog/commit/18554/2d7dfb7d84f4e693929280e7b18a3b0...
Comment #12
bbinkovitz commentedThese tests still aren't passing, as evidenced by the fact that patches aren't being tested by the bot because the branch has failing tests.
Comment #13
stevectorHi bbinkovitz,
Which test is failing? I just ran them locally and got all passes.
Comment #14
bbinkovitz commentedhttp://qa.drupal.org/pifr/test/201353
Comment #15
bbinkovitz commentedFailures were due to the bot using the wrong version of State Machine. Added version number to the info file, we'll see if that fixes it.
I think the testbot will not test this until it has already been tested :-/ I think we might need to commit it to get testbot to test.
Comment #16
bbinkovitz commentedMade the version more specific and/or sensical.
Comment #17
stevectorCommitted.
Comment #18
bbinkovitz commentedUnfortunately, the testbot failed the test again.
Comment #19
hass commentedYou may need test_dependency[]...?
Comment #20
dave reidYeah, since state_machine doesn't have an official 3.x release, I think you have to manually specify test_dependency[] as per #698932: "test_dependencies" for dependencies / integration tests
Comment #21
bbinkovitz commentedI think the problem may also have been that state_flow was specified as a dependency but state_machine was not.
Fixed both issues in latest patch.
Comment #22
hass commentedNote that test_dependencies does not work in the queue. It need to be committed and it works first after dev is rebuildnext time.
Comment #23
stevectorOn the IRC suggestion of Dave Reid, I'm trying just the addition of
dependencies[] = state_machine (3.x)Comment #24
dave reidWell, the new dependency was picked up successfully, but for some reason now the testbot has registered both 7.x-2.0 and 7.x-3.x of state machine to be dependencies and it cannot checkout the same module twice because the second time the folder already exists. We may need to open an issue with the test bots.
Comment #25
dave reidFiled issue #1903146: Duplicated dependencies causes checkout conflict in the testbot.