Rather than at message creation time, otherwise we get stale usernames in the activity stream.

CommentFileSizeAuthor
#4 1866488.commons_activity_streams.username_token.patch3.53 KBjpontani
#3 1866488.commons_activity_streams.username_token.patch8 KBjpontani
#3 1866488.commons_q_a.username_token.patch1.68 KBjpontani
#3 1866488.commons_follow.username_token.patch1.51 KBjpontani
#3 1866488.commons_like.username_token.patch1.51 KBjpontani
#1 Screen shot 2013-02-05 at 12.48.23 PM.png6.25 KBjacquelynfisher

Comments

jacquelynfisher’s picture

jacquelynfisher commented
StatusFileSize
new Screen shot 2013-02-05 at 12.48.23 PM.png6.25 KB

I am wondering if this is the reason that some old notices under Recent Site Activity are not displaying the usernames properly. (See screenshot). New notices by said user are displaying properly, and the only thing that came to mind was that the username was changed.

So if user tokens are replaced when the message is sent and not when the page is rendered, this might be why the username in the old notices (before the username change) are not displaying.

jpontani’s picture

jpontani commented
Assigned: Unassigned » jpontani
jpontani’s picture

jpontani commented
Status: Active » Needs review
StatusFileSize
new 1866488.commons_like.username_token.patch1.51 KB
new 1866488.commons_follow.username_token.patch1.51 KB
new 1866488.commons_q_a.username_token.patch1.68 KB
new 1866488.commons_activity_streams.username_token.patch8 KB

Committed to Wikis, and patches attached.

Using the @{message:user:name} token stores the username on the message at creation time, whereas using [message:user:name] token replaces it at render time.

http://drupalcode.org/project/commons_wikis.git/commitdiff/aea9f37

jpontani’s picture

jpontani commented
StatusFileSize
new 1866488.commons_activity_streams.username_token.patch3.53 KB

Disregard the Commons Activity Streams patch from above, it got messed up and included some incorrect stuff. Attached is the correct patch.

ezra-g’s picture

ezra-g commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

jpontani’s picture

jpontani commented
Status: Reviewed & tested by the community » Fixed

Committed.

http://drupalcode.org/project/commons_activity_streams.git/commitdiff/cf...
http://drupalcode.org/project/commons_like.git/commitdiff/228592f
http://drupalcode.org/project/commons_follow.git/commitdiff/0fd601e
http://drupalcode.org/project/commons_q_a.git/commitdiff/306d9a0

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.