* Removed the jumpy fade effect. I was thinking of doing something fancy but decided it was better doing it simple.
* Clear the OpenID field when clicking cancel, sort of a bug (test by filling in the field, go back and login normally - the OpenID login is fired)
* Removed the icon from the Cancel link.
* Clear out form_error message when going between login methods.
* Give the Cancel link a weight to have it under the login button on /user, just as in the block.
* Put focus on the textfields when going between login methods.
* Shortened some of the original jQuery code.

CommentFileSizeAuthor
#1 openid_login_form_0.patch4.57 KBanders.fajerson
openid_login_form.patch3.98 KBanders.fajerson

Comments

anders.fajerson’s picture

anders.fajerson commented
StatusFileSize
new openid_login_form_0.patch4.57 KB

As a bonus, here is a Konqueror friendly version that uses .css("display", "block") instead of .show(). Otherwise the same as above. The Konqueror problem was reported here and I could confirm it using Konqueror 3.5.8. I think it fits into this patch (and requeries the removal of the fade effect) so keeping it in the same issue for now.

BioALIEN’s picture

BioALIEN commented

+1 to the suggestions here. If Konqueror requires the removal of the fade to work with OpenID, then I'm all for it.

samirnassar’s picture

samirnassar commented

Well, this patch is Drupal 6 specific. I think in terms of Konqueror 3.5.8 and Drupal 5 this issue is a moot point. In terms of Drupal 6, KDE4 will be coming out fairly soon in 2008 which solves the issue.

I will try the patch against D6 this week and let you know how it behaves with Konqueror 4 betas as well as Konqueror 3.5.8

Actually feel free to send any Konqueror related patches my way for testing and such.

anders.fajerson’s picture

anders.fajerson commented
Category: task » bug

Still applies. Desperately needs testing. Bumping up to "bug" due to "Clear the OpenID field when clicking cancel" mentioned above and the Konqueror fix.

Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community

I just tested the patch in #1 against Konqueror 3.5.8, and was able to log in successfully. No flickry animation, just a successful login. Yay. The other changes appear to work as well, and in Firefox too. For the sake of all 3 Konqueror users, I'll RTBC this. :-)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

OK, committed, thanks.

anders.fajerson’s picture

anders.fajerson commented
Project: Drupal core » OpenID
Version: 6.x-dev » 5.x-1.x-dev
Component: openid.module » OpenID Client
Status: Fixed » Patch (to be ported)

I'm moving this to the OpendID project issue queue for backport to the Drupal 5 module (hopefully this is correct use of the issue queue, please correct me if I'm wrong).

walkah’s picture

walkah commented
Assigned: Unassigned » walkah

Totally acceptable use, fajerstarter. I'll make sure this gets backported!