Add requirement for Entity API.

What are the bugs? Are they things we could fix?

Whereas flag can leverage Entity API I don't think it requires it per-se, unless maybe some API calls are being made by mistake. What are the errors?

Closing.

I don't want to add a dependency, as I don't feel it adds anything for users of Flag.

However, I'd be fine with adding support for Entity API in ways that don't require the dependency.

I just wanted to check if adding a dependency to Entity API is still out of scope for this module? I am working an administration interface for a client and implementing the EntityAPIController would help a lot building the required functionality. The current entity implementation in Flag is atypical at least.

Implementing the EntityAPIController has few notable benefits:
- It removes the burden of implementing CRUD operations
- It is familiar for developers who work routinely with the Entity API
- It will make the transition to OOP in Drupal 8 considerably easier

I would be happy to contribute with patches and additional tests if you would consider integrating the Entity API into Flag.

I don't think we can add a dependency at this point in the development cycle.

I'm also unsure what it would provide:

- It removes the burden of implementing CRUD operations

We already have those in the flag_flag class.

- It is familiar for developers who work routinely with the Entity API

True, but flag has to do its own thing because of its API. You can't construct a flagging and just entity_save() it -- you'd be missing out all the Flag hook invocation and housekeeping.

- It will make the transition to OOP in Drupal 8 considerably easier

The D8 version of Flag is already underway, and AFAIK is a complete ground-up rebuild.

Could you explain more about what is missing, and what the pain points are?

Closed as outdated because Drupal 7 is EOL