Expand test coverage for ViewExecutable()

+++ b/core/modules/views/lib/Drupal/views/Tests/ViewExecutableTest.phpundefined
@@ -140,19 +161,58 @@ public function testDisplays() {
+    $view->setDisplay('invalid');
+    $this->assertEqual($view->current_display, 'default', 'If setDisplay is called with an invalid display id the default display should be used.');
+    $this->assertEqual(spl_object_hash($view->display_handler), spl_object_hash($view->displayHandlers['default']));

cool!

+++ b/core/modules/views/lib/Drupal/views/Tests/ViewExecutableTest.phpundefined
@@ -140,19 +161,58 @@ public function testDisplays() {
+    $this->assertFalse($view->use_ajax);
...
+    $this->assertTrue($view->use_ajax);

As a follow up we might want getUseAjax but sure this is out of scope here.

+++ b/core/modules/views/lib/Drupal/views/Tests/ViewExecutableTest.phpundefined
@@ -140,19 +161,58 @@ public function testDisplays() {
+    $this->assertNull($view->usePager());

We could document in the assertion message that the test_executable_displays view has the none pager documented.

+++ b/core/modules/views/lib/Drupal/views/Tests/ViewExecutableTest.phpundefined
@@ -140,19 +161,58 @@ public function testDisplays() {
+    $view->setOffset(5);
+    $this->assertEqual($view->getOffset(), 5);

What about using random integers?

+++ b/core/modules/views/lib/Drupal/views/Tests/ViewExecutableTest.phpundefined
@@ -140,19 +161,58 @@ public function testDisplays() {
+      'views_test_data' => true,
+      '#global' => true,

That's not true, it should be TRUE ;)

+++ b/core/modules/views/lib/Drupal/views/Tests/ViewExecutableTest.phpundefined
@@ -140,19 +161,58 @@ public function testDisplays() {
+  public function testDestroy() {

Tim patched in another issue to protected

+++ b/core/modules/views/lib/Drupal/views/Tests/ViewExecutableTest.phpundefined
@@ -202,21 +267,36 @@ public function testViewsHandlerTypes() {
+      $this->assertTrue(array_filter($validate, $match), "Error message found for $id display");

Shouldn't we use format_string instead (not sure).

Great work!

+++ b/core/modules/views/lib/Drupal/views/Tests/ViewExecutableTest.phpundefined
@@ -208,6 +219,44 @@ public function testPropertySettings() {
+    $path = $this->randomString(10);

any reason to use randomString and not randomName? randomString is a great source for potential random test failures, but yeah actually for paths it shouldn't be different.

+++ b/core/modules/views/lib/Drupal/views/Tests/ViewExecutableTest.phpundefined
@@ -208,6 +219,44 @@ public function testPropertySettings() {
+    $url = $this->randomString(10);
...
+    $arg1 = $this->randomString(10);
...
+    $title = $this->randomString(10);

Any special reason to use randomString(10) and not randomString()?

+++ b/core/modules/views/lib/Drupal/views/Tests/ViewExecutableTest.phpundefined
@@ -2,21 +2,24 @@
-class ViewExecutableTest extends ViewTestBase {
+class ViewExecutableTest extends ViewUnitTestBase {

+1!

+++ b/core/modules/views/lib/Drupal/views/Tests/ViewExecutableTest.phpundefined
@@ -55,7 +51,20 @@ class ViewExecutableTest extends ViewTestBase {
+    'parent_views'

Missing trailing comma

Otherwise, looks great!

RTBC when green!

#13: 1866804-13.patch queued for re-testing.

Yay test coverage!

Committed and pushed to 8.x. Thanks!