Final installation screen is not useful; include a redirect?

Thanks - adding the UX tag.

Yes, it is kind of funny. First, you have to squint and lean in closer to read a small link, then after having already stopping twice for input ... you more or less stop again just to shoot the breeze. A redirect for now would be nice, but it wouldn't hurt to plan on adding other options someday, such as

• Visit Site
• Import Content
• Backup site
• Security Review

Here's a patch. Unlike the approach at #1869468: During installation, users were mildly annoyed they immediately had to skip past default English language; streamline this?, it's not possible to simply skip this task of the installer, because that last step is doing all kinds of clean-up stuff. So I overrode the default install_finished() callback to one that does a drupal_goto() at the end and doesn't show any text.

WARNING: This patch includes that one, because they both touch the same area of code.

Also, since this really is talking about core's installer, not Commons's, I filed an upstream issue as well: #1870820: Ditch the last page of the installer?

We do the same thing in Commerce Kickstart, but we do have some code to not redirect if there are some errors or warnings.

I looked into what Commerce Kickstart does and followed their approach so that error messages will be displayed. I incorporated that change along with:

- Removing the deprecated "double feature revert" in commons_revert_features()
- #1869468: During installation, users were mildly annoyed they immediately had to skip past default English language; streamline this?
- #1869442: During installation, users were unsure about including demo content; needs clarification.

Thanks, everyone!

http://drupalcode.org/project/commons.git/blobdiff/a770bc30927685d3a5217...

One additional change in this commit was putting an array_filter() around the list of Acquia modules specified, since the Acquia Search was being enabled even when that module wasn't checked.

Restoring 7.x-3.x version property.