Which in effect means that cron execution from the admin page may have unexpected results, because the user may be permitted to do stuff that cron isn't really supposed to do.
The code that executes cron from the admin page - a call to elysia_cron_run() in elysia_cron_run_form_submit() - omits providing truthy $manual_run argument. Probably just a typo ;-)
However, the body of elysia_cron_run() has to be modified slightly too, because it currently treats all calls the same.
Thus it doesn't change the user to anonymous, even if given truthy $manual_run argument.
The issue applies to stable version 7.x-2.1 as well as 7.x-2.x-dev.
Will provide patches shortly.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | elysia_cron_7.x-2.x-manual_cron_run_anonuser-1867528-1.patch | 1.54 KB | jacobfriis |
| #1 | elysia_cron_7.x-2.1-manual_cron_run_anonuser-1867528-1.patch | 1.43 KB | jacobfriis |
Comments
Comment #1
jacobfriis commentedActually,
Thus it doesn't change the user to anonymous, even if given truthy $manual_run argument.wasn't true.
But it does mix up the algos for ordinary versus manual cron run.
Untested patch for stable version 7.x-2.1 attached.
Comment #2
jacobfriis commentedUntested patch for dev version 7.x-2.x attached.
Comment #3
gotheric commentedComment #4
nitebreedPatch works nice!
Comment #6
kala4ekChecked and committed to latest dev.