If we want to have any chance of re-using the field formatter for individual file field entries (rather than a full table), the row generation code needs to be broken out into a separate function.

This is the first step towards an eventual goal of enabling nodechanges diffs in comments to leverage the same field formatter as the field table, and thus reduce code duplication.

CommentFileSizeAuthor
#2 1867536_2.patch3.7 KBjthorson
#1 1867536.patch3.05 KBjthorson

Comments

jthorson’s picture

Status: Active » Needs review
StatusFileSize
new3.05 KB

Simple enough!

jthorson’s picture

StatusFileSize
new3.7 KB

Ooops ... needed to remove mass commented code.

jthorson’s picture

Status: Needs review » Fixed

Committed as 4ba86a.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.