Closed (fixed)
Project:
Entity Construction Kit (ECK)
Version:
7.x-2.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Dec 2012 at 22:39 UTC
Updated:
2 May 2015 at 21:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
fmizzell commentedComment #2
garphyI think it may be better to split this issue.
Exporting bundle 'config' key is critical but pretty printing the feature generated code is not and should be moved to a separate issue (with the corresponding patch).
The patch for the remaining concerns of this issue would become trivial and more prone to be quickly reviewed & committed.
Comment #3
romsP commentedI totally agree with you.
Comment #4
garphyThe patch works great here.
We now have 'language' related bundle settings included in features exports as well as our custom 'tsid' property bundle settings (see eck_i18n sandbox[1]).
IMHO this is a useful one-liner patch that should be committed.
Would be great is someone else who tested this fix could post its feedback in order to RTBC this issue.
[1] http://drupal.org/sandbox/garphy/1966680
Comment #5
simonyeldon commentedHad a look at the single line patch that adds config to the export array and it is exactly what we need.
Works perfectly, although I might suggest that we have the contents in alphabetical order (as that is what features 2 exports it as).
It would be good if this could be merged.
Comment #6
simonyeldon commentedRe-rolling the patch to allow it to be applied against the current Master.
Comment #7
kolier commentedPatch #6 is wrong, re-show patch #3.
Comment #8
marcusx commentedTestet patch from #3 https://www.drupal.org/node/1867614#comment-7463046. Can confirm that this adds language settings to the feature.
Comment #9
axe312 commentedI can confirm that patch #3 works with my RC4 installation of eck.
I had to force revert the features, but finally the bundle settings were updated on our development instance.
Comment #10
fmizzell commentedI guess if some config that eck supports is not going into a feature that is a bug, and not a feature..
Comment #11
joelstein commented+1 for the patch in #3.
Also note that it's currently impossible to revert bundles in Features, but this is fixed with the patch in #1733312-3: Bundles duplicates can be created from code - Features revert with bundles creates duplicates.
Comment #13
fmizzell commented