Problem/Motivation

This is a folllowup for #1535868: Convert all blocks into plugins.

BlockUpgradePathTest has the following assertion:

+++ b/core/modules/system/lib/Drupal/system/Tests/Upgrade/BlockUpgradePathTest.phpundefined
@@ -35,25 +35,23 @@ public function setUp() {
     $this->assertText('Block title cannot be longer than 255 characters', 'Block with title longer than 255 characters created unsuccessfully.');

"Created unsuccesfully" doesn't make any sense.

Proposed resolution

Remove the assertion message parameter for this assertion. The default assertion message for assertText() is sufficient to communicate what the assertion is testing.

Comments

xjm’s picture

Status: Active » Postponed

Oops, meant to postpone this on the main issue.

edrupal’s picture

Wasn't sure from post #1 if the patch was still needed but just in case, here it is.

xjm’s picture

Thanks @edrupal!

We'll want to check whether this patch applies once the issue linked in the summary is fixed. (It's postponed so that we do not conflict with that patch.)

xjm’s picture

Issue tags: +Blocks-Layouts
xjm’s picture

Status: Postponed » Needs review

Status: Needs review » Needs work

The last submitted patch, assertion_message_in_blockupgradepath_test_1867864_2.patch, failed testing.

xjm’s picture

Status: Needs work » Closed (duplicate)
Issue tags: +Block plugins

Looks like this actually got fixed in a different issue.

xjm’s picture

Issue summary: View changes

Updated issue summary.