Problem/Motivation
This is a folllowup for #1535868: Convert all blocks into plugins.
BlockUpgradePathTest has the following assertion:
+++ b/core/modules/system/lib/Drupal/system/Tests/Upgrade/BlockUpgradePathTest.phpundefined
@@ -35,25 +35,23 @@ public function setUp() {
$this->assertText('Block title cannot be longer than 255 characters', 'Block with title longer than 255 characters created unsuccessfully.');
"Created unsuccesfully" doesn't make any sense.
Proposed resolution
Remove the assertion message parameter for this assertion. The default assertion message for assertText() is sufficient to communicate what the assertion is testing.
Comments
Comment #1
xjmOops, meant to postpone this on the main issue.
Comment #2
edrupal commentedWasn't sure from post #1 if the patch was still needed but just in case, here it is.
Comment #3
xjmThanks @edrupal!
We'll want to check whether this patch applies once the issue linked in the summary is fixed. (It's postponed so that we do not conflict with that patch.)
Comment #4
xjmComment #5
xjmComment #7
xjmLooks like this actually got fixed in a different issue.
Comment #7.0
xjmUpdated issue summary.