Enable regular login by roles implementing a regular login permission.
Our use case is: 95% percent of users use PKI login, and 5% - admins, power users, moderators - must use regular login.

CommentFileSizeAuthor
#1 regular_login_permission_1868086.patch4.04 KBDrupa1ish

Comments

Drupa1ish’s picture

Drupa1ish commented
Status: Active » Closed (fixed)
StatusFileSize
new regular_login_permission_1868086.patch4.04 KB

Credit for EuroDomenii

rickwelch’s picture

rickwelch commented

Quick review of your patch looks like an extremely useful addition. Will fully review, integrate and push back to drupal.org on Monday.

Thanks!

-Rick

Drupa1ish’s picture

Drupa1ish commented

Big thanks also... Your extension saved my project!
Maybe you should include the keyword "digital signature" in the description of the project, for better indexing.

rickwelch’s picture

rickwelch commented

Thank you again for the patch. I have implemented it with following minor changes and pushed it back to the repository.

1) Rather than hard coding the validators for user_login I placed your validator just before the final validation.
2) Added your suggested configuration settings validator.
3) Very minor tweaks to verbiage.

Please let me know if I've missed or misunderstood anything. Again thanks for the excellent addition. I am sure that I will use this myself in future projects.
Cheers!
-Rick

Drupa1ish’s picture

Drupa1ish commented

Great review... Everything looks ok. Unfortunately, I don't have the time to test it now. I shall do it asap.

Drupa1ish’s picture

Drupa1ish commented

All tests ok.
To respect drupal standards, maybe we should replace regular_login permission with regular login ( without underscore)

rickwelch’s picture

rickwelch commented

Sorry for the delay. Thanks for the feedback and good catch on the underscore! This has been fixed and pushed back to origin. I hope to rework some of the documentation later this week to reflect the changes.

Again, thank you for the patch and feedback.