To help with #1402860: Panelizer is incompatible with moderation it would be useful if it was possible to customize the node history page.

CommentFileSizeAuthor
#10 workbench_moderation-n1868144-10.patch2.17 KBdamienmckenna
#9 workbench_moderation-n1868144-9.patch1.44 KBdamienmckenna
#7 workbench_moderation-n1868144-7.patch1.33 KBdamienmckenna
#4 workbench_moderation-n1868144-4.patch1.48 KBdamienmckenna
#1 workbench_moderation-n1868144.patch539 bytesdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new workbench_moderation-n1868144.patch539 bytes

This adds drupal_alter('workbench_moderation_node_history_view', $rows);

xtfer’s picture

xtfer commented
Status: Needs review » Reviewed & tested by the community

This is such a minor patch I can't see any issues with RTBC'ing it. Its "working" locally for me.

stevector’s picture

stevector
he/him
commented
Status: Reviewed & tested by the community » Needs work

Interesting idea. Thanks for the patch.

A change like this would at least need an entry in workbench_moderation.api.php since it introduces a new hook. Can you give me an example of how you're using it?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new workbench_moderation-n1868144-4.patch1.48 KB

I'm trying to use it over in #1871552: Panelizer does not work well with workbench and entity revisions. to aid with integrating Workbench Moderation with Panelizer.

How does this patch work for you?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
hass’s picture

hass commented
Status: Needs review » Needs work 
+++ b/workbench_moderation.api.phpundefined
@@ -66,3 +66,24 @@ function hook_workbench_moderation_states_next_alter(&$states, $current_state, $
+    if ($published) {
+      $row['data']['revision'] .= ' | ' . l('Panelizer', 'node/' . arg(1) . '/panelizer');
+    }
+    else {
+      $row['data']['revision'] .= ' | ' . l('Panelizer', 'node/' . arg(1) . '/revisions/' . $row['data']['vid'] . '/panelizer');
+    }

This example could be optimized. First add the links to an array and after the foreach(), execute an implode(' | ', $foo)

Looks good to go than.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new workbench_moderation-n1868144-7.patch1.33 KB

I tidied up the hook_workbench_moderation_node_history_view_alter() example in the API file.

Status: Needs review » Needs work

The last submitted patch, 7: workbench_moderation-n1868144-7.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new workbench_moderation-n1868144-9.patch1.44 KB

Fixed a typoo, and added a comment above the drupal_alter() call.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new workbench_moderation-n1868144-10.patch2.17 KB

Updated with more documentation for the hook and an improved example.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#1871552: Panelizer does not work well with workbench and entity revisions.

Is this something the 1.x maintainers are interested in?