Closed (fixed)
Project:
Drupal Commons
Version:
7.x-3.0-beta1
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
17 Dec 2012 at 06:07 UTC
Updated:
4 Feb 2013 at 23:10 UTC
The Libraries API module version 2 and 2.x-dev seem to break the Module Filter 1.7 module when installed together. The filter and tabs of Module Filter stop working when I installed Libraries. However, if I uninstall Libraries, the Module Filter module immediately starts working again. I don't see any errors on the screen or in the dblog.
Module Filter 1.7 was included as part of Drupal Commons 7 beta. I don't know if this module is *actually* incompatible with Libraries API or if it is some sort of weird combination of modules causing the problem. The only other module installed beyond what is included in Commons 7 beta is Admin Menu.
Comments
Comment #1
greenskin commentedWhat libraries are you using? It sounds like a JavaScript error. If you have a JavaScript library being loaded by the Libraries API that contains an error, it could prevent Module Filter from functioning correctly.
Comment #2
jlea9378 commentedThe only library is grammar_parser-7.x-1.2
also using the module grammar_parser_lib-7.x-1.1
I need them for using Coder Upgrade.
Comment #3
greenskin commentedDo you get any JavaScript errors? What browser are you using?
Comment #4
jlea9378 commentedSo I have another site that uses the same versions of Grammar Parser and Libraries. I installed Module Filter on there just now and it works perfectly fine. So it seems to be something with Commons 7. The problem only appeared when I enabled Libraries on there, and would disappear when I disabled Libraries.
Our Commons 7 site is down at the moment, so I can't check the Firefox Error Console for JS errors right now, but once the site is back up I will try to recreate the problem and check for you.
Using Firefox 17.0.1 on Win7 x64.
Comment #5
jlea9378 commentedThe only errors I see are these:
--
[21:15:02.842] TypeError: jQuery.timeago is undefined @ http://comm7.he2236.vps.webenabled.net/profiles/commons/modules/contrib/...
[21:15:03.618] TypeError: jQuery(...).timeago is not a function @ http://comm7.he2236.vps.webenabled.net/profiles/commons/modules/contrib/...
But those errors were present before I enabled Libraries. And Module Filter only breaks after I enable Libraries. I can't disable Timeago because it is required by a dozen other modules (Commons modules).
Comment #6
greenskin commentedDoes your other site you mentioned present those same JavaScript errors (jQuery.timeago errors)?
Comment #7
jlea9378 commentedNope it isn't a Commons 7 site, and thus does not have the Timeago module. It's just an ordinary Drupal 7 site.
Comment #8
greenskin commentedDo you have the file /profiles/commons/modules/contrib/timeago/timeago.js? This is a necessary step for Timeago to work, and not something Commons can necessarily include in it's download. It depends on what license the library uses.
Comment #9
jlea9378 commentedyes, timeago.js and jquery.timeago.js both exist, at that location.
Comment #10
greenskin commentedThis might actually need to be moved to Timeago's project issue queue. Either the jquery.timeago.js file is not getting included in the page or it's being included after timeago.js. Do you see the jquery.timeago.js file in the document head?
Comment #11
geigerg commentedhttp://drupal.org/node/1826586#comment-6709704
Comment #12
Chipie commentedI had the same error as soon I enabled the library module. #11 fixed my problem. Thank you.
Comment #13
ezra-g commentedComment #14
jlea9378 commentedI installed the patch mentioned in #11 but the errors haven't gone away. Is there something I need to do after running the patch command? The file modified was a make file, so I'm thinking there is another step...
Comment #15
Topcheese commented@jlea9378, sorry I haven't had a chance to get back to this issue. I was wondering when you say you installed the patch, did you also move the location of the file as mentioned?
Edit: Also forgot to note that it says to use the latest Timeago DEV version.
Comment #16
jlea9378 commentedI just updated to:
commons-7.x-3.0-beta1+12-dev
I haven't installed the patch again. Is that still necessary? Will that get rid of the errors below?
I also installed timeago library to the correct location.
I still see this on the Status Report page:
Warning: fopen(): http:// wrapper is disabled in the server configuration by allow_url_fopen=0 in timeago_get_version() (line 114 of /home/clients/websites/w_comm7/public_html/comm7/profiles/commons/modules/contrib/timeago/timeago.install).
Warning: fopen(http://timeago.yarp.com/jquery.timeago.js): failed to open stream: no suitable wrapper could be found in timeago_get_version() (line 114 of /home/clients/websites/w_comm7/public_html/comm7/profiles/commons/modules/contrib/timeago/timeago.install).
Despite these errors that appear on the Status Report, I AM able to enable the Module Filter module now, and it DOES work.
Comment #17
ezra-g commentedI'm working to integrate Libraries module into Commons and CKEditor as part of #1879036: Replace Aloha with CKEditor via CKEditor project, which should resolve the present issue.
Folks who want to help with that effort can work on #1063482: Use Libraries API for CKEditor.
Comment #18
ezra-g commentedI believe this is fixed by #1879036: Replace Aloha with CKEditor via CKEditor project, which introduced the Libraries module into Commons and changed the location of the TimeAgo library.