After creating first flag, 'Manage fields' link goes to flag edit page

Clearing cache fixes it, though not sure why the menu path isn't registering in the first place. Will look into it.

Ah, it's because we've been returning no bundles to entity info until that point. Hence the menu paths don't exist.

We need to clear entity info cache when it's the first flag we're saving.

Hmm on second thoughts, we should probably clear entity cache whenever a flag is new, as other things may want to know there's a new bundle.

I don't think that's the case -- once the menu path exists for one flag, it exists for all of them because it uses a wildcard.

I think what you rather mean is that if you don't clear the cache after the first flag, it carries on not working. Which is because you still don't have the menu path registered.

Tagging.

Here's a reworked patch.

Could someone try this out on a site with no flags? Thanks!

Committed.

Probably needs a backport, since 'Issue #1699328 by socketwench: Moved the bookmark flag to its own sub-module.' was committed on the 2.x branch before 3.x branched off. Nope, I wasn't reading git log properly.

untag