Node clone duplicates UUID

Thanks for adding this patch. I just tested it, and it looks like it does the trick for the uuid field.

It looks like the revision ids and comments are being cloned too though. So, I tried editing your patch to see if the same would work for those fields...

function uuid_clone_node_alter(&$node, $original_node, $method) {
  $node->uuid = '';
  $node->vid = '';
  $node->log = '';
}

I think $node->log = ''; works to prevent the revision comments from being cloned. But, $node->vid = ''; didn't seem to do anything to prevent vuuids from being cloned. So, I think there is still a problem with the revision VUUID being cloned.

The attached image shows the results I was getting when I tested this.

Thanks for adding the patch. If we can fix the vuuid part, then I think that would solve this issue.

Thanks Chris. It looks like I made a mistake and used "vid" instead of "vuuid". Maybe that's all it needs. I'll try testing this again soon, and hopefully that will fix it.

Ok... will do. I'll try testing this again later today, and let you know if it works.

I tested the patch with the extra two lines of code that I added. It worked, so this seems to be the fix that is needed in uuid.core.inc.

I don't have a patch for this, but this is the code to fix the problem:

function uuid_clone_node_alter(&$node, $original_node, $method) {
  $node->uuid = '';
  $node->vuuid = '';
  $node->log = '';
}

The change in #8 solves the issue for us, including in translation and revision (ERS) test cases.

I made a patch from #8 and will try to trigger the automated tests again...

Are these tests being postponed because theres something wrong with the patch? Maybe we need a dependency on node_clone somewhere.

node_clone isn't not part of core, it is a contrib module. This needs to be fixed in the node_clone module. It doesn't introduce a hard dependency on UUID, so there is nothing stopping the fix landing there.

I made a patch for setting uuid, vuuid, and log to NULL in clone_node_prepopulate() and clone_node_save(). I'm not sure if this is necessary anymore for the vuuid and log (node_revisions), because I didn't notice a problem with them when I tested it this time.

Seems to work for me, but please test to confirm. Thanks.

I reviewed the patch and worked like a charm!

This problem was really messing things up when using UUID, and with others modules like Services UUID.

I just add a simple module_exists() to check if the UUID is enabled to the patch of @mixxmac in #12.

Cheers!

Works well for me.

Works well with Node export and Features.
Must be added to the next release candidate.

Why is the module_exists() needed?

needs re-roll for refactoring in [#1316284 ]

this simple?

committed #18

What stopped/is stopping this from being merged?

Never mind. I see this was merged to the 7.x and 8.x branches.

oops, yeah - just failed to mark it fixed