Download & Extend
CKEditor - WYSIWYG HTML editor » Issues

[D7] Move skin selection option to CKEditor Global Profile

Posted by dczepierga on December 17, 2012 at 12:15pm
Project:CKEditor - WYSIWYG HTML editor
Version:7.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

From CKEditor v4 is not possible to use more than 1 skin on the page, so this option is moved to Global Profile - from now it wouldn't be possible to use 2 diffrent skins by switching text format in textarea.

Login or register to post comments

Comments

#1

Posted by dczepierga on December 17, 2012 at 12:21pm

Changes commited to GIT (diff).

#2

Posted by dczepierga on December 17, 2012 at 12:21pm
Status:active» fixed

#3

Posted by hass on December 18, 2012 at 1:35pm
Status:fixed» needs work
  • Line breaks in translatable strings are not supported in potx.
  • Backtick's shouldn't used. This is not Drupal code style. Use <em> instead, please.
  • !skin should be changed to %skin for security reasons. It's only a name and no html with tags, isn't it? !skin qualifies for a security issue.
  • l() is not allowed in translatable strings.
  • editg link has for sure no trailing /

+    drupal_set_message(t(
+      'The `CKEditor Global Profile` profile is using `!skin` skin which cannot be found. Please !profile_settings.', array(
+        '!skin' => $global_profile->settings['skin'],
+        '!profile_settings' => l(t('update your settings'), 'admin/config/content/ckeditor/editg/')
+      )

Correct example:

<?php
drupal_set_message(t('The <em>CKEditor Global Profile</em> profile is using %skin skin which cannot be found. Please <a href="@profile_settings">update your settings</a>.', array('%skin' => $global_profile->settings['skin'], '@profile_settings' => url('admin/config/content/ckeditor/editg'));
?>

#4

Posted by dczepierga on December 19, 2012 at 7:38am
Status:needs work» fixed

@hass, really thx for help.

All changes commited to GIT (diff)

#5

Posted by mkesicki on December 22, 2012 at 12:46pm
Status:fixed» closed (fixed)
nobody click here