The current implementation of hook_field_attach_create_bundle(). is broken because it's checking for the wrong field instance.

CommentFileSizeAuthor
#9 title-autoattach_broken-1869438-9.patch3.9 KBplach
#2 title-fix-hook-field-attach-create-bundle-1869438-2.patch1.68 KBjsacksick

Comments

jsacksick’s picture

jsacksick commented
Title: Automatic title field replacement doesn't work » hook_field_attach_create_bundle() implementation isn't correct
jsacksick’s picture

jsacksick commented
StatusFileSize
new title-fix-hook-field-attach-create-bundle-1869438-2.patch1.68 KB
jsacksick’s picture

jsacksick commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, title-fix-hook-field-attach-create-bundle-1869438-2.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs work » Needs review

#2: title-fix-hook-field-attach-create-bundle-1869438-2.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, title-fix-hook-field-attach-create-bundle-1869438-2.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs work » Needs review
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

#2: title-fix-hook-field-attach-create-bundle-1869438-2.patch queued for re-testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs review » Fixed
StatusFileSize
new title-autoattach_broken-1869438-9.patch3.9 KB

Committed and pushed the attached patch, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 1d7b73b on 7.x-1.x, workbench authored by jsacksick, committed by plach: 
    Issue #1869438 by jsacksick: Fixed hook_field_attach_create_bundle()...