Hi,
I know this is a minor - but it was really irritating me as I get repeated notices whilst developing.
Within hook_tokens, a notice is thrown when trying to retrieve from $data[$type] - as no check is made to see if this object exists, prior to the assignment.
What I've done is add an array of types specific to hansel (to reduce the code needed to check the assignment) and then added the checks to the existing checks.
It makes more sense when you see the patch, which is attached.
- Rob
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | hansel-notices-fix-1869630-4.patch | 1.13 KB | ezeedub |
| #3 | hansel-notices-fix.patch | 1.26 KB | robinmofo |
| hansel-notices-fix.patch | 1.23 KB | robinmofo |
Comments
Comment #1
robinmofo commentedForgot to set to bot test .
Comment #2
robinmofo commentedBah, I committed the wrong ver!
Comment #3
robinmofo commentedI'm so sorry - I've made a bit of a mess of this post within 5 mins!
Here is the correct patch ready for review.
Comment #4
ezeedub commentedNew patch, slightly modified.
Comment #5
pgillis commentedThis patch works for me. I couldn't apply directly, probably because I have some other patches applied already. That said, it was easy to apply manually and worked fine.
Comment #6
pgillis commentedGiven my above comments in #5 it's been working for us in dev installation for a couple of months
Comment #7
robinmofo commentedAnd we've been using this in production for 6-7 months now.
Comment #8
mauritsl commentedCommitted to GIT. Thanks!