I tried searching the issue queue for this but didn't see it anywhere.

It looks like there is no custom permission to administer this module. Currently, our store managers should only have access to create orders, add products, etc.

And at the moment they cannot manage any settings (a good thing) with the exception of this module and I have almost every popular commerce addition active.

Am I missing something?

CommentFileSizeAuthor
#13 admin_permission-1869930-13.patch4.22 KBguy_schneerson
#12 admin_permission-1869930-12.patch4.25 KBguy_schneerson
#10 admin_permission-1869930-10.patch1.44 KBguy_schneerson
#3 patch_commit_881d0bfce27e.patch1003 bytesharrrrrrr

Comments

guy_schneerson’s picture

guy_schneerson commented

@dwatts3624 thanks for you input
We currently use the "administer commerce_product entities" permission, Do you think we need a more specific one like "configure commerce stock"?

Would be easy to add however I am a bit worried about existing installs as they will need to update their permission, but we are on Alpha so I think should be ok.
Will look into adding this in the new year.

dwatts3624’s picture

dwatts3624 commented

Good point about upgrading but I think this is a must to align with other critical commerce modules (which this is one of in my opinion).

Thanks for the attention here!

harrrrrrr’s picture

harrrrrrr commented
Version: 7.x-2.0-alpha3 » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new patch_commit_881d0bfce27e.patch1003 bytes

patch for 1.x branch which gives you a seperate 'administer stock settings' permission

guy_schneerson’s picture

guy_schneerson commented

Hi @harrrrrrr was a bit afraid of this one see #1 but as #dwatts3624 in #2 stated we need it.
So thanks and will review and commit.

heyyo’s picture

heyyo commented

Would be nice to have this commited on 2.x branch also. Thanks.

guy_schneerson’s picture

guy_schneerson commented
Assigned: Unassigned » guy_schneerson

Hi @heyyo for sure, will get this in both versions soon.
Asigning to myself so I can pick this up next time I work on the module.

guy_schneerson’s picture

guy_schneerson commented
Status: Needs review » Fixed

Thanks @dwatts3624 and @harrrrrrr
Committed http://drupalcode.org/project/commerce_stock.git/commit/4170b56

guy_schneerson’s picture

guy_schneerson commented

Also updated the readme

guy_schneerson’s picture

guy_schneerson commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Fixed » Patch (to be ported)

Version 2 may need finer granularity.

guy_schneerson’s picture

guy_schneerson commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new admin_permission-1869930-10.patch1.44 KB

V2 patch attached
Created a separate issue for #1998358: Administer Stock rules actions permissions

guy_schneerson’s picture

guy_schneerson commented
Status: Needs review » Needs work

need to add to simple stock configuration

guy_schneerson’s picture

guy_schneerson commented
StatusFileSize
new admin_permission-1869930-12.patch4.25 KB

Added simple stock configuration
Also added access check for the rules configuration admin page need 'administer rules' permission.

guy_schneerson’s picture

guy_schneerson commented
StatusFileSize
new admin_permission-1869930-13.patch4.22 KB

removed an unneeded commented line.

guy_schneerson’s picture

guy_schneerson commented
Title: Administer Stock Configuration? » Administer Stock Configuration permission
Status: Needs work » Fixed

Reviewed, tested & committed to v2 http://drupalcode.org/project/commerce_stock.git/commit/176cd58

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Edited language.