In credentials form validation the code fails to account for sites that use proxy for creating a connection to SF. The validation calls salesforce_api_connect() in salesforce_api_settings_form_validate at which point proxy settings are not saved yet and SF connection will always fail.

Patch to follow.

CommentFileSizeAuthor
#1 1870742.patch1.54 KBnonsie

Comments

nonsie’s picture

nonsie
she/her
Primary language Estonian
commented
Status: Active » Needs review
StatusFileSize
new 1870742.patch1.54 KB

Patch moves connection test to the loading of the form rather than to the validation of the form.

aaronbauman’s picture

aaronbauman
he/him
commented
Component: salesforce_api » Code
Status: Needs review » Needs work

The point of doing this during validation is to make sure that the credentials work before any existing credentials are overwritten.

A proper fix would allow for salesforce_api_connect() and salesforce_api_login() to take additional parameters to set a proxy at call time, rather than only rely on a variable. A temporary fix would be to determine, during validation, whether to check the connection based on whether a proxy is being added or updated.

kostajh’s picture

kostajh commented
Status: Needs work » Closed (won't fix)

Closing this issue. See #2124817: 7.x-2.x and 6.x-2.x branches are no longer supported for more info.