Breadcrumb is showing "Home" even on frontpage.

CommentFileSizeAuthor
#4 home_no_breadcrumbs.patch648 bytesdvessel
#3 no_breadcrumb_on_frontpage-2.patch661 bytesrobloach
#1 no_breadcrumb_on_frontpage.patch4.46 KBrobloach

Comments

robloach’s picture

robloach
he/him
commented
Title: Breadcrumbs present on frontpage » Regression: Breadcrumbs present on frontpage
Status: Active » Needs review
StatusFileSize
new no_breadcrumb_on_frontpage.patch4.46 KB

In Drupal 5.x, the breadcrumb was hidden on the front page, so this is a regression issue.

Adding a simple check to if (!drupal_is_front_page()) { before setting the breadcrumb fixed it. There might be a better way of fixing this.

robloach’s picture

robloach
he/him
commented
Version: 6.0-beta2 » 6.x-dev

This is also still persistent in 6.x-dev.

robloach’s picture

robloach
he/him
commented
Component: other » menu system
StatusFileSize
new no_breadcrumb_on_frontpage-2.patch661 bytes

Refactored to use a simpler if statement.

dvessel’s picture

dvessel commented
StatusFileSize
new home_no_breadcrumbs.patch648 bytes

Rob, placing that within a menu function is trouble. The front page check was removed when chx was overhauling the menu system a while back. Forgot to put it back in.

scoutbaker’s picture

scoutbaker commented
Status: Needs review » Reviewed & tested by the community

Tested the patch in #4.

Steps:

  1. Opened the front page of the unpatched site - verified that Home breadcrumb shows
  2. Patched menu.inc
  3. Opened the front page of the patched site - verified that the Home breadcrumb did not show
  4. Clicked on one of the story links on the front page - verified that the Home breadcrumb shows
  5. Clicked on Home - verified that the breadcrumb disappears again.

This seems so simple, I'm going to go out on a limb and mark it RTBC.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.