Book made simple causes permission problems when using book access

Perhaps this is due to the fact that the two modules are overriding outline menu access.
As i don't know book_access and your configuration, can you remove in book_made_simple.module in book_made_simple_menu() function these lines :

  $items['node/%node/outline'] = array(
    'title' => 'Outline',
    'page callback' => 'book_outline',
    'page arguments' => array(1),
    'access callback' => 'book_made_simple_is_outline_access',
    'access arguments' => array(1),
    //'access arguments' => array("show core Outline tab"),
    'type' => MENU_LOCAL_TASK,
    'weight' => 10  ,
    'file' => 'book.pages.inc',
    'file path' => drupal_get_path('module', 'book'),
  );

Clear your cache and retry

I'm going on vacation until January 2d
I'll have a look to this issue on my return.

hey i'm the maintainer for book_access, just wanted to chime in here.

i'm going on holidays too, but Marc if you need any assistance on my end to figure it out (i'd like book_access to be a good citizen to other modules, code-wise), i'll be glad to help.

Any help is always appreciated !
I will contact you on my return.

Problem was due to the fact both modules redefine outline access function.
I've modified BMS to use hook_menu_alter rather than hook_registry_alter.
These modifications have been commited to dev but i post patch too.

But there's another problem. As both module are using hook_menu_alter, book_access weight (actually 2) must be greater than BMS weight (actually 10) to override BMS actions.

BMS needs to be high to be sure hook_node_insert is called after all modules hooks.
@thelee, does Book_access can be set to greater than 10 ?
If yes, the weight of book_access must changed in database for the moment.
Maybe can we work with @thelee for a better integration.

EDIT : Don't forget to clear caches.

Yes, I believe it would be fairly trivial to make the change to the weight. I'll have to take a look at it later when things calm down a bit here.

Have you clear caches ?
Can you give me book_access and bms permissions ?

Can you post me permissions of

• Administer book outlines
• Show (checked) or hide (unchecked) core book reorder tab,
• Show (checked) or hide (unchecked) core Outline tab
• Show (checked) or hide (unchecked) outline section in form elements.

It is normal that only admin can see Reorder because Show (checked) or hide (unchecked) core book reorder tab perm is only checked for admin role.
You said in #9 you see reorder tab in all pages. This happens only for admin role ?

For reorder tab problem, replace in book_made_simple.module (line 108)

  if (user_access('administer books')) return true;
  if (isset($node->book) && $node->book['bid'] > 0) {

by

  if (isset($node->book) && $node->book['bid'] > 0) {
    if (user_access('administer books')) return true;

There was a bug due to refactoring.
Can you replace in book_made_simple.module line 750

    $items['node/%node/outline']['access callback'] = 'is_outline_access';

By

    $items['node/%node/outline']['access callback'] = 'book_made_simple_is_outline_access';

1) I can't reproduce problem. Maybe corrected by #17. Don't forget to clear menu caches
2) Have you applied this patch ( http://drupal.org/node/1871124#comment-6865556 )?

Try Administration Menu

I had the same problem when i tried Book Access. I had to rebuild all node permissions in admin/content/book/settings by click on "Save and reset all books to defaults" button

Looks fine for me.
How do you see author has no permission ?

Works for me (for admin or authenticated user).
See my permissions in screenshot

Have you changed weight of book_access to 12 by updating system table ?

Yes. You must do this. Don't forget to rebuild cache

Glad to have helped you !

Sorry it took me a while, but this is the patch that I'll be using for book_access's side (basically just changing the weight in hook_install).

Great.
Many thanks for your help

Marc

correction

Hi,

I'm using the two devs version (book access and BMS) and I still have this problem.

I want book access to control all right on books, and the only thing I can do is to allow users to show or not theirs books to the others (visibility on book is working).

I definitily want to allow users to have possibility to choose who can edit and manage book access settings for each book they own.

The facts are :

- When I check "content type can only be created inside a book" (in the content type settings for child page) to avoid people to add child page to books they are not allowed to, nobody is allowed to add child page (even if it's the author of the book). Moreover, outline tab is visible on each book page whereas I want users to see the outline tab only for the books they have right to add child to (with book access).

- When I check "only creator can add child pages" (in the content type settings for book page), the outline tab is visible for the author and no one else, but if I grant access to somebody in book access to add child page, he can't see the outline tab.

I know my problem seems to be complicated, moreover it's difficult to me to explain it in my native langage it's even more difficult to explain it in english.

Hope somebody could help me, knowing those previously patchs should have resolved my problem, which is similar to this topic.

I can tell you more about my problem if needed.

for those hitting this, you'd need to uninstall book_access, apply the above patch to book_access and then re-install.

with that said, surely can come up with a better patch, one that includes hook_update also

The patch seems like a reasonable and simple solution, could be improved by adding a hook_update