Download & Extend

Check if database logging is enabled before running database upgrade 7005

Project:Metatag
Version:7.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Found a minor bug:

If the system module Database logging is not enabled, update 7005 will fail, not allowing the remaining updates to complete. The simple fix is to enable Database logging. Might consider adding a check to see if that module is enabled first when running 7005 because it won't need to remove anything from the watchdog table if the table doesn't even exist to remove anything from.

I realize that the majority will have Database logging enabled but sometimes it gets overlooked (as in my case)...

Comments

#1

More specifically the check should probably see if the "watchdog" table even exists and if not, skip the 7005 update. As it is, it just errors out saying that it can't find the watchdog table because it doesn't exist and none of the remaining updates seemed to run.

#2

Title:Database Upgrade 7005 Error» Check if database logging is enabled before running database upgrade 7005
Status:active» needs review

Making the title more explicit with what needs to happen.

AttachmentSizeStatusTest resultOperations
1871852_ensure_table_exists_before_deleting.patch551 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 11 pass(es).View details

#3

#2 Patch worked perfect for me.

#4

Status:needs review» reviewed & tested by the community

Gah, thanks greggles.

Once #1798294: Can't edit non-current node revisions is resolved I'll commit this.

#5

Status:reviewed & tested by the community» fixed

Committed #2 to 7.x-1.x.
http://drupalcode.org/project/metatag.git/commit/6e56165

#6

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here