Closed (fixed)
Project:
Project issue tracking
Version:
5.x-2.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
27 Oct 2007 at 23:37 UTC
Updated:
14 Nov 2007 at 18:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
dwwTested on mysql -- works as advertised and code is fine. My only minor concern was that core already enables comments by default on all node types -- you have to go out of your way to disable them, so that particular variable_set() isn't strictly necessary. But, this defends us against possible future changes in core's default, so what's in here is fine.
Comment #2
hunmonk commentedcommitted to HEAD.
Comment #3
dwwArgh, that's what I get for being hasty...
That variable set in fact breaks things. ;) devel.module says:
tee hee. seems as though the define()'s at the top of comment.module aren't available inside hook_install() like this. :(
Comment #4
dwwOh, and while we're at it, we don't need those single quotes around '1' like that for the other 2 settings, either...
Comment #5
dwwHrm, yeah, I guess this is only a problem when you use an install profile. However, I'm not sure there's much we can do about it in a profile, since we're already including project_issue *after* comment in the list of modules to enable in the d.o testing profile. And, since this variable_set() was only to "future proof" the code, I don't really want to fight install.php and all that for something so trivial (and unnecessary). So, how about this?
Comment #6
hunmonk commentedcode looks good.
Comment #7
dwwComment #8
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.