Address Field Taiwan

Hi,

It gave me a 404 on the git link provided by you above.

Please provide a link to clone the git repository in the "issue summary".

You need to delete the master branch in your repository. Refer point 6. http://drupal.org/empty-git-master

You need to remove LICENSE.txt as this will be added automatically by drupal.org

Please remove the coding standard errors- http://ventral.org/pareview/httpgitdrupalorgsandboxgloomcheng1872126git

Regards,
Arjun

Hi, Fu-yuan Cheng!

Thanks for your module.

My manual review.

1) The file is filled addressfield_tw.install rather massive database query, not easier to add data to the database using db_insert()?
2) This file is used addressfield_tw.inc huge number of functions that return only the data in an array. Is not it easier to use a single function that will return the data based on the received argument?

Best Wishes,
Andrew Podlubnyj.

Hi,

Thanks, this sounds like a useful module!

From an initial look, I have a couple of points below:

• As you're still using the master branch, you will need to switch to a version specific branch and remove master, e.g 7.x-1.x. Release naming conventions.
• Your project description page is quite short, some good tips for creating a project page can be found here.

Hello,

I've corrected git repository link and remove LICENSE.txt

I was unable to clone project using your link. Please, correct and check it again.

In your master branch version I have noticed that you have install function, but didn't use uninstall function. Please, note, that users should have an ability to delete it at any time.

I not delete the master branch yet that I haven't enough time

Also, please, use status "needs review" only when your project is ready for review.

Correct git link.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (found some problems with the project) or "reviewed & tested by the community" (found no major flaws).

Hi gloomcheng, if you are still interested in contributing this module to d.o, I can help you to review the module.
FYI, I encountered an error after installing the module, more details here: https://drupal.org/node/2053565

Correct GIT link.