When cloning a node without specific settings the default is cloned rather then inserting nothing as expected.

This because an issue when the default changes and nodes affected by this maintain the old settings rather then updating to the new.

relevant functions:
panelizer_node_insert() and panelizer_load_node_panelizer()

Version 7.x was not checked for this issue.

CommentFileSizeAuthor
#3 default_clones-1872388-2.patch1.21 KBlostkangaroo

Comments

merlinofchaos’s picture

I think the issue is on saving.

What really needs to happen is, when saving a node, we need to detect properly if the panelizer is a default. It may require some additional work to tell the difference, but there may already be some differences we can detect. For example, I think a default panelizer will have some CTools Export information on it that a node specific panelizer will not have.

I don't think this problem will appear in 7.x because that system works totally differently, and it already checks for stuff like this.

lostkangaroo’s picture

I can agree with that. Here is a patch that checks to see if any changes were made to the form itself before creating a new record for node defaults. In a way this makes it more difficult to change node behavior accidently.

lostkangaroo’s picture

StatusFileSize
new1.21 KB

Okay I think I have the patch upload thing figured out now.

lostkangaroo’s picture

Status: Active » Needs review
neclimdul’s picture

That actually fixes a different issue that the clone bug we where discussing. We could open that as a different issue to discuss that but its less pressing then the clone issue.

merlinofchaos’s picture

Status: Needs review » Fixed

I'm not really doing anything with D6 anymore, so I pushed this without doing any testing.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.