I've run this for close to a week now and B&M has created a backup every day, yet I only have one single backup, 7 hours old. Apparently, Prune has removed all the others. This is not how I understand the specs on the front page and in the module.

After this has run for a while (with a daily scheduled backup and possibly some manual backups) I would expect to see the following: All backups younger than 24 hours are still there and for the past 7 days (actually days 2 to 7) there's one backup per day.

Going with only one (very recent) backup for up to 7 days is irresponsible.

Comments

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Version: 7.x-1.1 » 7.x-1.x-dev
Assigned: Unassigned » e0ipso
Priority: Major » Critical
Status: Active » Needs review

There has been a massive rewrite of this module on the dev branch.

Would it be possible to get your backups back and test the behavior with the new code?

salvis’s picture

salvis
he/his
commented
Status: Needs review » Fixed

After applying the patch in #1872674: Tries to delete .. (the parent directory) locally to 1.1, this has improved. Maybe it was the deleting of '.' that produced the behavior that I reported in this issue here.

My current state is the following:

1. I did a lot of testing on Dec 22 and there are still about 10 backups from that date around. I would have expected this to drop to 1 by now, but given your "massive rewrite" I don't think we need to pursue this here and now.

2. I have backups dated Dec 23, Dec 24, and Dec 25, and the next one is due in two hours. These are now preserved, and I consider this issue fixed with the patch in the other thread.

I'll install the -dev version and see how it behaves. It's difficult to test Prune — we just have to let it run and take its course...

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented

Let me know if you find any more bugs. As you say, testing is not easy… maybe it would be worth to write relevant tests. I'll take that into account.

Remember that your backups on Dec 22 will only be pruned if there is a gardener in for that destination (manual backup destination?)

salvis’s picture

salvis
he/his
commented

Maybe you can create a mock file system that presents four year's worth of files, between zero and three backups per day, let a gardener do its thing and then check what's left. Then advance the mock clock and check how it develops.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented

I will open a new issue for proper testing.

http://drupal.org/node/1881384

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.