Sandbox url: http://drupal.org/sandbox/alechko/1873456

Git: http://git.drupal.org/sandbox/alechko/1873456.git

jQuery Tablehover plugin
========================

This plugins helps navigate in tables, highlighting the hovered rows and columns,
and provides ability fo fix highligh by clicking on a cell.

To install just enable the module.

From here, the hovering functionality is enabled, but to enable the fixate highlight by click,
you must add ".tablehover-click" class to your table.

There are 3 optional versions of .js files to use with this module:
1. Uncompressed - 13.8K
2. Minified - 3.2K
3. Packed -2.9K

By default the minifed version is selected, you can change to other types from:
admin/config/user-interface/tablehover

NOTES:
Plugin source http://p.sohei.org/jquery-plugins/tablehover/
All credit goes to the author, whoever he is...

Comments

cackle’s picture

cackle commented

Hello,
First correct your git url from git.drupal.org:sandbox/alechko/1873456.git to http://git.drupal.org/sandbox/alechko/1873456.git
Automated review found some issues. Please, see http://ventral.org/pareview/httpgitdrupalorgsandboxalechko1873456git from more details to fix it.
I will try to test it manually.

monymirza’s picture

monymirza
Primary language Urdu
Location Islamabad
commented
Status: Needs review » Needs work
alechko’s picture

alechko commented

Hello guys, thank you for reviewing my module.

I've corrected most of the issues found by the DrupalCS module and the automated review, and
managed to narrow the errors for all files except the original jquery plugin files, which I did not touch.

alechko’s picture

alechko commented
Status: Needs work » Needs review
fr3shw3b’s picture

fr3shw3b commented
Status: Needs review » Needs work

Hi,

There are still a lot of minor formatting errors flagged by the automated review tool:
http://ventral.org/pareview/httpgitdrupalorgsandboxalechko1873456git

Manual Review:

1. It is best to use the Libraries module to add your tableHover jquery plugin as it is a third party plugin and remove the inc folder.
http://drupal.org/project/libraries

2. Best to avoid using hook_init and attaching using the libraries API to load the plugin when needed to particular hooks.
You can find out more about using the Libraries API for that here:
http://drupal.org/node/1342238

3. File doc blocks needs to be more informative and you need full stops to meet the coding standards at the end of comments.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (found some problems with the project) or "reviewed & tested by the community" (found no major flaws).

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes

Changed git url