[D7] Commerce Pay2Pay

First of all, it seems that your module is a payment method for Drupal Commerce module.

The second point: You don't need such complex file structure, your module files is located here but they should be located at the root of your module direcory. You don't need file pay2pay_payment_gateway_module.info.
You don't have to specify version in info file, it will be added automatically when release build will be published.

All code and text should be in UTF8 encoding with UNIX-style line ending. You can read about coding standards here.

README.TXT should be placed in root directory of the module and its name should be in uppercase.

Also, code should be in version specific directory. You can read about that here.

Also you need to fix all issues found by the automated check.

updating status

Hi pay2pay,

Manual Review:

1) Please add more information of your module to project page.
2) Please check your directory structure and files again.
3) Use proper santization function in commerce_pay2pay_get_settings() function.

Automated Review:

Result of automated code review.

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• README.txt is missing, see the guidelines for in-project documentation.
• ./modules/commerce/modules/payment/modules/pay2pay/commerce_pay2pay.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (found some problems with the project) or "reviewed & tested by the community" (found no major flaws).

I have refactored module and fixed all issues of automated review. Please, review it.

Changed: module works with Drupal Commerce, not with Drupal e-Commerce.

Manual Review

• The module info page could be better. The contents of README.txt are really good! You could copy that information onto your module page.
• It would be helpful to have some more in-line comments - particularly in the bigger functions. The doc blocks for each function are really good.
• A couple of strings in commerce_pay2pay_settings_form need to be wrapped in t(). They currently just have brackets around them (lines 91 & 92 of .module)
• There are some direct access to $_POST[] which is bad practice in most cases.

Automated Review

• Pareview through up a couple of coding standards issues http://ventral.org/pareview/httpgitdrupalorgsandboxpay2pay1873772git-7x-1x

Apart from those things everything looks good.

@rlmumford, thanks for your feedback. I have fixed all issues you've stated above. Please, review once more.

There are some direct access to $_POST[] which is bad practice in most cases.

The notification data from Pay2Pay is getting in $_POST that's why I can't not to use it.

PS: if it's possible, I would be grateful if git vetted user role was granted to BerdArt, since the topic starter is representative of the Pay2Pay support and isn't interested in further contribution. All work on module was done by me and my colleagues.

Short and sweet, looks good to me.

----
Top Shelf Modules - Enterprise modules from the community for the community.

PAReview: Individual user account

It seems you are using a non-individual account.
All user accounts are for individuals. Accounts created for more than one user or those using anonymous mail services will be blocked when discovered (see Get a Drupal.org account).
Please change your account information and enter your realname.

Also, you need to sanitize or validate these values from POST

  $xml = base64_decode(str_replace(' ', '+', $_POST['xml']));
  $sign = base64_decode(str_replace(' ', '+', $_POST['sign']));

----
Top Shelf Modules - Enterprise modules from the community for the community.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Added first review bonus