Download & Extend
Lightweight Directory Access Protocol (LDAP) » Issues

LDAP SSO: Error "Undefined index: URL in ldap_sso_path_excluded_from_sso" in ldap_sso.module

Posted by bigMuzzy on December 25, 2012 at 12:16pm
Project:Lightweight Directory Access Protocol (LDAP)
Version:7.x-2.x-dev
Component:Code
Category:bug report
Priority:minor
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Lines 93 and 97 contains a reference to an array element $_SERVER['URL']. It's wrong cause we have no an element named as 'URL'. Right choice is: $_SERVER['REQUEST_URI'].

Because of his bug we have errors:

•Notice: Undefined index: URL in ldap_sso_path_excluded_from_sso() (line 93 of C:\www\portal\sites\all\modules\ldap\ldap_sso\ldap_sso.module).
•Notice: Undefined index: URL in ldap_sso_path_excluded_from_sso() (line 97 of C:\www\portal\sites\all\modules\ldap\ldap_sso\ldap_sso.module).
Login or register to post comments

Comments

#1

Posted by johnbarclay on January 7, 2013 at 5:01pm
Status:active» fixed

This is fixed in 7.x-2.x-dev. See #1787816: LDAP SSO: add option to exclude some URLs (like cron.php) from automatic SSO.

#2

Posted by bigMuzzy on January 17, 2013 at 12:08pm
Priority:major» minor
Status:fixed» needs work

It's not true for now. I have errors in "Recent log messages" (admin/reports/dblog):

Notice: Undefined index: URL in ldap_sso_path_excluded_from_sso() (line 93 of C:\www\portal\sites\all\modules\ldap\ldap_sso\ldap_sso.module).
Notice: Undefined index: URL in ldap_sso_path_excluded_from_sso() (line 97 of C:\www\portal\sites\all\modules\ldap\ldap_sso\ldap_sso.module).

File ldap_sso.module contains these lines:

90:  if ($path) {
91:    // don't derive
92:  }
93:  elseif ($_SERVER['URL'] == '/index.php') {
94:    $path = $_GET['q'];
95:  }
96:  else {
97:    $path = ltrim($_SERVER['URL'], '/'); // cron.php, etc.
98:  }

As you see lines numbered 93 & 97 have been trying to receive value from $_SERVER array by 'URL' index.

#3

Posted by johnbarclay on January 28, 2013 at 5:55am
Title:Eroor "Undefined index: URL in ldap_sso_path_excluded_from_sso" in ldap_sso.module» LDAP SSO: Error "Undefined index: URL in ldap_sso_path_excluded_from_sso" in ldap_sso.module
Status:needs work» fixed

This was committed on jan 7th. See http://drupalcode.org/project/ldap.git/blame/refs/heads/7.x-2.x:/ldap_ss...

-dev just means the most current commit on the branch. You have to get a new one to have the current -dev anytime a commit has been made.

#4

Posted by bigMuzzy on January 30, 2013 at 6:32pm

Thanks, now it's OK.

#5

Posted by System Message on February 13, 2013 at 6:40pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#6

Posted by RoyK on March 20, 2013 at 10:39am
Status:closed (fixed)» active

Looks like there's a bug in there after all. in ldap_sso/ldap_sso.module, lines 93 and 97, $_SERVER['URL'] used. This is not a valid $_SERVER index, but changing it to $_SERVER['PHP_SELF'] works. This is from ldap-7.x-2.0-beta3.tar.gz

roy

#7

Posted by johnbarclay on March 20, 2013 at 12:29pm
Status:active» needs work

We need a patch that accommodates the various web server environments on this and doesn't throw errors.

#8

Posted by johnbarclay on March 25, 2013 at 3:19pm
Status:needs work» fixed

#6 is old code. This particular ldap sso issue is closed.

#9

Posted by System Message on April 8, 2013 at 3:20pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here