I added action-support to this module (http://drupal.org/project/actions) so that the permissions can be set using the workflow module (http://drupal.org/project/workflow).
And I surrounded some strings with t('') to make them translateable.
The patch is attached to this issue.

CommentFileSizeAuthor
patch_1.diff5.29 KBkkaefer

Comments

ankur’s picture

ankur commented

Hey, thanks for the patch. Is there any chance you could re-submit the patch using the diff guidelines posted by killes: http://drupal.org/patch

It's easier to read with the +'s and -'s (which are output with respect to function names when you execute diff with "-uF^f" as the options)

I plan on doing a port of this module soon and am looking for some ideas in addition to some things I want to fix/modify.

-Ankur

ankur’s picture

ankur commented

This patch was committed without the maintainer's approval. I'll approve the addition of action support when actions become a part of Drupal core. As for the translatable strings: a seperate patch is encouraged.

Feel free to start a seperate branch if you wish to add action support. Just don't commit to HEAD or DRUPAL-4-6.

The maintainer for this project is typically over-extended, so in the future: if you have a patch that is sitting on this queue and you'd like a quick, confirmed approval or denial from him, contact him with the send form on his user profile page: http://drupal.org/user/11703

-Ankur

ankur’s picture

ankur commented