Using the menu in RTL languages scambles the menu. File exists, but more work is needed to make it work correctly.

CommentFileSizeAuthor
#8 interdiff.txt13.07 KBjessebeach
#2 navbar rtl issure.png15.54 KBrajab natshah
#2 navbar rtl issure fix.png15.26 KBrajab natshah
#2 fix-icons-and-border-for-rtl-1873974-2.patch2.21 KBrajab natshah
#5 fix-icons-and-border-for-rtl-the-7.x-1.x-dev-1873974-5.patch606 bytesrajab natshah
#3 fix-icons-and-border-for-rtl-the-7.x-1.0-alpha10-1873974-3.patch218 bytesrajab natshah
#4 fix-icons-and-border-for-rtl-the-7.x-1.0-alpha10-1873974-4.patch650 bytesrajab natshah

Comments

jessebeach’s picture

jessebeach commented
Status: Active » Needs review

Fixed in 7.x-1.x (21db0460625cf81f1eff3b5a9ac7c28aec1c4252).

druvision, would you mind testing?

rajab natshah’s picture

rajab natshah
he/him
commented
StatusFileSize
new fix-icons-and-border-for-rtl-1873974-2.patch2.21 KB
new navbar rtl issure fix.png15.26 KB
new navbar rtl issure.png15.54 KB

I'm getting it as you can see in figure 1

Figure 1
Figure 1 :

I have a quick css fix as in the patch file.
so it will look as you can see at figure 2

Figure 2
Figure 2 :

in the navbar.theme-rtl.css file

.navbar .tray .menu li a {
  padding-right: 2.3333em;
}

.navbar .horizontal .menu li:last-child {
  border-left: 1px solid #dddddd;
}
rajab natshah’s picture

rajab natshah
he/him
commented
StatusFileSize
new fix-icons-and-border-for-rtl-the-7.x-1.0-alpha10-1873974-3.patch218 bytes

Not this one.

rajab natshah’s picture

rajab natshah
he/him
commented
StatusFileSize
new fix-icons-and-border-for-rtl-the-7.x-1.0-alpha10-1873974-4.patch650 bytes

Oh This is the right patch fix for 7.x-1.0-alpha10..

rajab natshah’s picture

rajab natshah
he/him
commented
StatusFileSize
new fix-icons-and-border-for-rtl-the-7.x-1.x-dev-1873974-5.patch606 bytes

This patch for the 7.x-1.x-dev
I'm testing the navbar --dev in an other testing site.

hass’s picture

hass commented
Status: Needs review » Needs work

Outdated patch

hass’s picture

hass commented
Version: 7.x-1.0-alpha3 » 7.x-1.x-dev
jessebeach’s picture

jessebeach commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt13.07 KB

I've updated the *-rtl.css files (fb22a802fb8213d5eefbea73b0e7d49fc5dad441).

rajab natshah’s picture

rajab natshah
he/him
commented

Please, If this is fixed to the dev and alpha we should close this issue.

hass’s picture

hass commented
Status: Needs review » Fixed

Looks committed. Setting to fixed. Let's reopen a new case if something is broken.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.