It seems that when viewing a form submission, labels that are marked as "hidden" show up regardless of the component setting.

The "hidden"-flag works fine when submitting the form.

Comments

danchadwick’s picture

danchadwick commented
Title: Hidden labels showing when viewing submission » Label = 'none' showing when viewing submission
Issue summary: View changes

I have reproduced this, but I'm not sure it's a bug. Without any label, it would be hard to see what the data is. @quicksketch -- was this intentional behavior?

quicksketch’s picture

quicksketch
he/him
commented

I don't think this is intentional. The only time a hidden label should be shown is if using a token to specifically retrieve the label itself, such as [submission:values:my_field:label]. All other times the setting should be obeyed, whether viewing the result or using other tokens.

danchadwick’s picture

danchadwick commented
Version: 7.x-4.0-alpha6 » 7.x-4.0-rc6
Status: Active » Fixed

Actually, both inline and no label are broken. There are two problems.

  1. Each component needs to set #title_display when displaying a submission as html (rather than as a form).
  2. webform.css was not being added to the submission display page.

Committed to 7.x-4.x and 8.x

  • DanChadwick committed e738917 on 7.x-4.x 
    Issue #1874344 by DanChadwick: Fixed title_display not honored when...
  • DanChadwick committed fa0b8eb on 8.x-4.x
    Issue #1874344 by DanChadwick: Fixed title_display not honored when...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.