On an inactive/invalid domain, users should be able to login, at the least.

We should add a hook inside domain_invalid_domain_requested() that allows alteration of the behavior based on the current request path.

CommentFileSizeAuthor
#3 1874442-domain-invalid-request.patch5.53 KBagentrickard
#1 1874442-domain-invalid-request.patch1.7 KBagentrickard

Comments

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Needs work
StatusFileSize
new 1874442-domain-invalid-request.patch1.7 KB

Initial patch. Creates a new hook and implements it to allow user login.

Needs tests.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

The proper test here is:

a) Does the hook fire for the domain_test module?
b) Does the hook return FALSE on 'node'?
c) Does the hook return TRUE on 'user/login'?
d) If a user logs in on an invalid domain, and has a role that allows the user to access inactive domains, is the user _not_ redirected on login.

This tests fine in the browser, but needs automation.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs work » Needs review
StatusFileSize
new 1874442-domain-invalid-request.patch5.53 KB

And a patch with those nice tests.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Fixed

Committed.

   0afecaa..0813047  7.x-3.x -> 7.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.