Download & Extend
Issues

Revise Create.js-related code when upstream issues have been fixed

Posted by Wim Leers on December 27, 2012 at 3:33pm
Project:Drupal core
Version:8.x-dev
Component:edit.module
Category:task
Priority:normal
Assigned:Wim Leers
Status:closed (fixed)
Issue tags:Spark

Issue Summary

Problem/Motivation

Create.js makes too simplistic assumptions in some areas, forcing us to have more and uglier boilerplate code than necessary.

Proposed resolution

The problems have been discussed with the Create.js maintainer and will be fixed before a Create.js 1.0 release (they've been marked as blockers).

Remaining tasks

  1. Help get upstream issues fixed.
  2. Leverage the fixes to achieve cleaner code.

User interface changes

None.

API changes

None.

Login or register to post comments

Comments

#1

Posted by Wim Leers on March 1, 2013 at 2:41pm

As part of #1886566: Make WYSIWYG editors available for in-place editing, I worked on improving the naming of the different PropertyEditor widgets. Instead of:

Drupal.drupalContentEditableWidget

this:
DrupalEditEditor.direct

But then I ran into ridiculous problems because jQuery UI Widget works in ways that are completely beyond all common sense: http://stackoverflow.com/questions/7739525/jquery-ui-how-to-call-a-widge.... (namespaces aren't actually namespaces in jQuery UI Widgets.)

So I had to use "bridging" to be able to use namespaces:
jQuery.widget.bridge('DrupalEditEditor_direct', jQuery.DrupalEditEditor.direct);

Unfortunately, that breaks with Create.js: https://github.com/bergie/create/issues/166. Hence, that issue is now also listed in the issue summary.

#2

Posted by Wim Leers on May 15, 2013 at 2:10pm
Assigned to:Anonymous» Wim Leers
Status:active» closed (fixed)

#1979784: Factor Create.js and VIE.js out of the Edit module removed Create.js and VIE.js, so this was implicitly fixed there.