Posted by xjm

Problem/Motivation

This is a followup issue for #1535868: Convert all blocks into plugins. It should also be postponed on other refinements to the block UI.

There are several CSS bugs in the Block Library user interface (tested with Chrome in a window under 1024px wide with the most recent version of the patch):

  • The search box is too wide and escapes from the sidebar in a smaller window.
  • The ordered list of facets in the right sidebar has an abnormally wide left margin.
  • The "Add custom block" button is misaligned.

CSS bugs

Proposed resolution

  • Ensure these CSS bugs are resolved once the Blocks and Layouts UI is complete.

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Block plugins
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Postponed » Active

That search box one in particular looks egregiously stupid. I'd be happy to commit a patch that fixed it, whether or not SCOTCH fails. :P

dcrocks’s picture

dcrocks commented

An issue, #1880368: Form elements can break out of their bounding divs and whatnot, was created for that. Perhaps it should be marked as a duplicate?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Actually, I kinda like addressing this on its own separately because although the alignment and margin stuff ought to be cleaned up too, the search box is just a glaring visual bug.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Component: block.module » CSS
Priority: Normal » Minor

Ok, search box escaping was fixed. Hooray! The rest of these are quite minor.

Re-classifying as CSS to hopefully get some more eyes on it. I think with the tags this should be ok.

echoz’s picture

echoz commented

I'm working on a fix for this in modules/system/system.plugin.ui.css and I have the following questions:

  1. This will need a RTL file, don't we need to change "left" + "right" to "first" + "second" respectively, in system.plugin.ui.css + templates/system-plugin-ui-form.tpl.php? If so, anyplace else?
  2. This file, system.plugin.ui.css has no @file comment at the top, what is the description (plugin column styles, assuming not specific to blocks)?
  3. Can I fix the yucky css coding standard errors at the same time in such a small file of no space between property + value?
echoz’s picture

echoz commented

Should this go back to status "postponed"?

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Active » Postponed

Re-postponing since the current prototype eliminates this UI entirely.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes

Removing myself from the author field so that I can unfollow the issue. --xjm

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue summary: View changes
Status: Postponed » Closed (won't fix)

system.plugin.ui.css doesn't exist any more. If we've eliminated the UI this should be closed, no need to mark this postponed.