Active
Project:
Apps
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
28 Dec 2012 at 18:52 UTC
Updated:
3 Oct 2014 at 23:00 UTC
Jump to comment: Most recent, Most recent file
Fixed some typos and wording in apps.api.php. Patch below.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | apps-fix-coding-standarts-and-doc-1875766-9.patch | 49.77 KB | mglaman |
Comments
Comment #1
shadcn commentedComment #2
pfrenssenGreat job, but it needs some more work. I have only reviewed the first function, but these remarks apply to the entire page. I'd also want to extend the scope of this issue to also make sure this page conforms to coding standards.
Comment #3
babruix commentedFixed found issues, in some places documentation still doesn`t have @param description.
This patch fixes many coding standarts issues and added/fixed documentation.
Comment #4
babruix commentedComment #5
pfrenssenThis is already much better, but there still remain some problems. When I examine the file with the Coder module:
Comment #6
pfrenssenDid some more cleanups. Some work still remaining:
Comment #7
babruix commentedFound issues fixed, please review.
Comment #8
mglamanReally need this. However does not apply against latest dev. re-roll incoming.
Comment #9
mglamanBegan review with Coder.
Was "Coder found 1 projects, 21 files, 7 critical warnings, 52 normal warnings, 500 minor warnings, 0 warnings were flagged to be ignored"
Now "Coder found 1 projects, 21 files, 7 critical warnings, 43 normal warnings, 250 minor warnings, 0 warnings were flagged to be ignored"
Still needs work. Also updated title.
Comment #11
hefox commentedpatch defiently an improvment so commited as is
Comment #13
hefox commentedGot a few more, but think it needs a manual once over and there's some @todo about function description