Download & Extend
Issues

Wrong variable name in hook_menu_delete documentation

Posted by ivanjaros on December 28, 2012 at 9:19pm
Project:Drupal core
Version:7.x-dev
Component:documentation
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:needs backport to D7, Novice

Issue Summary

In documentation for hook_menu_delete: http://api.drupal.org/api/drupal/modules!menu!menu.api.php/function/hook_menu_delete/7

there is a '$link' insted of '$menu'.

Login or register to post comments

Comments

#1

Posted by jhodgdon on January 2, 2013 at 6:30pm
Version:7.x-dev» 8.x-dev

Good catch!

While we're fixing this, first line should be changed from "Inform modules that..." to say "Respond to...".
http://drupal.org/node/1354#hooks

#2

Posted by ParisLiakos on January 13, 2013 at 1:51pm
Version:8.x-dev» 7.x-dev
Issue tags:-needs backport to D7

This got fixed for d8 in #1814916: Convert menus into entities

#3

Posted by cck on January 15, 2013 at 4:47am
Assigned to:Anonymous» cck

D7 patch for #1.

AttachmentSizeStatusTest resultOperations
menu-hook_delete_wrong_param-1875858-1.patch1.33 KBIdlePASSED: [[SimpleTest]]: [MySQL] 39,674 pass(es).View details

#4

Posted by j.slemmer on January 15, 2013 at 11:59am
Status:active» needs review

#5

Posted by jhodgdon on January 15, 2013 at 6:36pm
Version:7.x-dev» 8.x-dev
Status:needs review» needs work

There is still a problem in D8 that needs to be addressed (which is addressed in this d7 patch, but we need to fix d8 before fixing d7): the first lines of all the hook docs in menu.api.php are incorrect. So can we get a patch for d8 that fixes them as in the existing d7 patch? Thanks!

Oh actually, the d7 patch says things like:

Respond to a custom menu was created.

That isn't very good English. How about "Respond to custom menu creation"? And similar for the other hooks.

#6

Posted by ParisLiakos on January 15, 2013 at 6:47pm
Issue tags:+needs backport to D7

oops,seems i missed #1..sorry for the noise.restoring tag as well

#7

Posted by cck on January 15, 2013 at 10:13pm

Ok. I will follow up on this.

#8

Posted by cck on January 16, 2013 at 12:33pm
Status:needs work» needs review

This D8 patch corrects the subject line.

AttachmentSizeStatusTest resultOperations
menu-hook_delete_wrong_param-1875858-6.patch1.07 KBIdlePASSED: [[SimpleTest]]: [MySQL] 50,878 pass(es).View details

#9

Posted by jhodgdon on January 16, 2013 at 2:56pm
Status:needs review» needs work

Thanks! Please change "Responds" to "Respond" -- see
http://drupal.org/node/1354#hooks

#10

Posted by cck on January 17, 2013 at 1:19am
Status:needs work» needs review

Hi, the correction is included in this version.

AttachmentSizeStatusTest resultOperations
menu-hook_delete_wrong_param-1875858-9.patch1.07 KBIdlePASSED: [[SimpleTest]]: [MySQL] 50,910 pass(es).View details

#11

Posted by jhodgdon on January 17, 2013 at 5:27pm
Assigned to:cck» jhodgdon
Status:needs review» reviewed & tested by the community

Looks good! I'll get this committed to 8.x shortly, and then we can return to the 7.x patch.

#12

Posted by jhodgdon on January 17, 2013 at 11:13pm
Version:8.x-dev» 7.x-dev
Status:reviewed & tested by the community» needs work

Thanks again -- Committed the patch in #10 to Drupal 8.

Now we can return to the patch in #3 for Drupal 7, which needs the first lines of the hook documentation to look like the patch in #10.

#13

Posted by j.slemmer on January 17, 2013 at 11:34pm
Status:needs work» needs review

How about this? See patch...

AttachmentSizeStatusTest resultOperations
menu-hook_delete_wrong_param-1875858-13.patch1.05 KBIdlePASSED: [[SimpleTest]]: [MySQL] 39,656 pass(es).View details

#14

Posted by cck on January 18, 2013 at 3:09am
Status:needs review» needs work

Hi, -13 patch needs another fix in hook_menu_delete. You can look at -1.patch. This @link parameter is fixed in D8. This is why it is not included in the D8 patch.

#15

Posted by j.slemmer on January 18, 2013 at 9:25am

Added that change. How about now?

AttachmentSizeStatusTest resultOperations
menu-hook_delete_wrong_param-1875858-15.patch1.32 KBIdlePASSED: [[SimpleTest]]: [MySQL] 39,762 pass(es).View details

#16

Posted by j.slemmer on January 18, 2013 at 9:26am
Status:needs work» needs review

#17

Posted by jhodgdon on January 18, 2013 at 11:39pm
Status:needs review» reviewed & tested by the community

Looks good -- thanks! I'll get this committed shortly.

#18

Posted by jhodgdon on January 19, 2013 at 3:59pm
Assigned to:jhodgdon» Anonymous
Status:reviewed & tested by the community» fixed

Thanks again -- this is committed to 7.x.

#19

Posted by System Message on February 2, 2013 at 4:00pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here