Domain TAC

Please take a moment to make your project page follow tips for a great project page.
This module has less code so we cannot assign GIT vetted role to you as mention here we can promote this as a single project.

please get a review bonus first. Then try to fix issues raised by automated review tools and set this back to "needs review".

This is a small bridge module that deserves release on its own merits. As it stands, neither Domain Access or Taxonomy Access Control are the proper location for this small module.

I nominate this project to be promoted manually.

Hi.
Unfortunately this project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed.
However, I have promoted this single project manually to a full project for you.

Note: Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.
git remote set-url origin [your_git_username]@git.drupal.org:project/domain_tac.git

There are some minor notes recorded on http://ventral.org/pareview/httpgitdrupalorgsandboxlittleguysolutions187... regarding code standards you may want to fix.
And one minor suggestion from me:
In line 98 of domain_tac.module you probably may simply use the following code insted of tow nesteed foreach:

<?php
foreach ($user_domains as $user_domain) {
  $grants["domain_tac_{$user_domain}"] = array_values($user_groups);
}
?>

Thanks for you contribution and to the dedicated reviewers as well.

I object to the method here. Setting an arbitrary standard of length over functionality is bad practice.

This is a welcome bridge module that has no home otherwise -- unless you want to push it to Github and drive users away from d.o.

And if you want to reject it again, I'll just create the project myself and then transfer project node ownership to the original author.

Uhm sorry Ken, but I guess you misunderstood my comment.
The project has been manually promoted to a full project (http://drupal.org/project/domain_tac) by me so "LittleGuySolutions" can handle it like all the other full projects on drupal.org.

To approve "LittleGuySolutions" as a vetted git user the code is simply too short, but this has nothing to do with the module itself (which is - as you said - a welcome bridge that wouldn't fit in one of the bridged modules).
There is a quasi-standard on how much lines of code a module needs to approve a user as git vetted user. The discussion about this is at http://groups.drupal.org/node/195848.

Setting to "fixed" again, since the project application is completed by promoting the sandbox to a full project. If "LittleGuySolutions" would like to create another project he needs to run through the review process again (I've no doubts he will get the status when providing a more complex module).

Stefan

Awesome, thanks.

Apologies if I misunderstood the last post.