I use views calc in a view where I have Bulk Operations (VBO). The checkboxe for "select all" is showing in the table header but in each row the checkboxes don't appear. Is there a workarround or do I have to respect some other settings to make this work?

CommentFileSizeAuthor
#12 views_calc-1876594-12.patch1.06 KBroball
#6 views_calc-1567108.patch1.77 KBa.milkovsky
#5 views_calc-theme_render_fix-1876594-6896978.patch936 bytesa.milkovsky
#2 views_calc_7.x-1.0-theme.inc_render_fix.patch1.09 KBa.milkovsky

Comments

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
commented

The same... I can see only html comment in the table cell

<td class="views-field views-field-views-bulk-operations  ">
   <!--form-item-views_bulk_operations---->          
</td>
a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
commented
Status: Needs review » Active
StatusFileSize
new views_calc_7.x-1.0-theme.inc_render_fix.patch1.09 KB

I've compared "Views calc display" template_preproccess hook and the same hook in Views module views\theme\theme.inc for the "Table display".

I've noticed that in views table fields are rendered in different way:

  // Fields must be rendered in order as of Views 2.3, so we will pre-render
  // everything.
  $renders = $handler->render_fields($result);

Here is my patch fix that resolved the issue

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
commented
Status: Active » Needs review
manuelBS’s picture

manuelBS commented
Status: Active » Closed (fixed)

For me that patch #2 works.
I hope that patch will make it in views_calc module because we need it to work with views bulk operations

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
commented
StatusFileSize
new views_calc-theme_render_fix-1876594-6896978.patch936 bytes

i've changed the path in the patch

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
commented
Status: Closed (fixed) » Needs review
StatusFileSize
new views_calc-1567108.patch1.77 KB

patch update.
needs review

manuelBS’s picture

manuelBS commented

Works for me, thanks

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
commented
Status: Needs review » Reviewed & tested by the community

ok. So I'm changing it to "reviewed & tested by the community"

mr.alinaki’s picture

mr.alinaki commented

This patch works for me, thanks!

bocaj’s picture

bocaj commented
Issue summary: View changes

Manually applying this patch on 1.1 worked fine for me! It would be great to get this committed!

roball’s picture

roball commented
Version: 7.x-1.0 » 7.x-1.1
Status: Reviewed & tested by the community » Needs work

Sorry, but patch at #6 does not apply:

[root@server views_calc]# patch --dry-run -p1 < views_calc-1567108_0.patch
patching file theme.inc
Hunk #1 succeeded at 186 (offset 5 lines).
Hunk #2 FAILED at 311.
1 out of 2 hunks FAILED -- saving rejects to file theme.inc.rej
roball’s picture

roball commented
Title: Checkboxes of views Bulk Operations not working » No checkboxes of Views Bulk Operations
Version: 7.x-1.1 » 7.x-1.x-dev
Status: Needs work » Needs review
StatusFileSize
new views_calc-1876594-12.patch1.06 KB

Patch from #6 rerolled against latest 7.x-1.x branch. Works fine for me. Thanks a.milkovsky!

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
commented
Status: Needs review » Reviewed & tested by the community

Thank you for re-rolling. Works for me too.

azmchichi’s picture

azmchichi commented

Hi,

What about "Select all items on all pages" ? It doesn't work with this patch.

Thank you !

giupenni’s picture

giupenni commented

#12 works fine for me.