Ability to submit jobs for languages even if there is no user yet that has the necessary capabilities it (configurable)

Patch with test coverage.

Not sure I follow you ;)

Job creators have no control over this, the admin who configures the translator does. The settings is added to the translator settings, not the checkout settings.

For now, I'm going to assume that these two persons are the same and even if not, it wouldn't change anything about the storage, we'd just need to expose it as a UI to the LUI manager.

The server should respect the languages returned by the translator, then this should just work.

I'm fine with defaulting this to on, but that will conflict with the auto-approve default value patch.

Ah, now I understood what was confusing @cgalli about this.

The job validation considers the capabilities, so you could only submit the job if you had at least one user in your system that was able to translate that language.

The assign list, however, did not. It listed *all* translators, if they were able to translate the job or not. Added test coverage for that and fixed it in an ugly way because the capabilities API is so limited and functionality is mixed between skills and local modules. What's important is the test coverage, because it will allow us to refactor the implementation later on.

Uh, with patch.

That's my fault, the test should work though.

And yes, the explode is fine, passing a comma separted list through GET is way easier than as an array.

+++ b/translators/tmgmt_local/tmgmt_local.moduleundefined
@@ -508,6 +512,32 @@ function tmgmt_local_task_statuses() {
+ * @param array $tasks
+ *   Array of tasks ids.
...
+function tmgmt_local_tasks_languages($tasks) {

Ok.

While it's fine to pass it through as a string, we should be consistent internally and always convert it to an array. If you call explode(',', '1'), it will just return an array with a single value?

Then we can type hint $tasks to array here to be consistent with the @param.

No, the opposite.

The API function only accepts an array and ensures that with (array $tasks). The submit function makes sure that it converts $tasks to an array.

+++ b/includes/tmgmt.entity.incundefined
@@ -845,7 +845,7 @@ class TMGMTJobItem extends Entity {
       $status = $this->getData($key, '#status');
-      if (!$status || $status == TMGMT_DATA_ITEM_STATE_PENDING) {
+      if (!$status || $status == TMGMT_DATA_ITEM_STATE_PENDING || $status == TMGMT_DATA_ITEM_STATE_PENDING) {

This is unrelated.

+++ b/translators/tmgmt_local/includes/tmgmt_local.pages.incundefined
@@ -399,11 +403,15 @@ function tmgmt_local_translation_assign_form_submit($form, &$form_state) {
+  if (strpos($tasks, ',') !== FALSE) {
+    $tasks = explode(',', $tasks);

The check here is not necessary. Make sure it's always an array.

+++ b/translators/tmgmt_local/tmgmt_local.moduleundefined
@@ -508,6 +512,32 @@ function tmgmt_local_task_statuses() {
+  $query->join('tmgmt_job', 'j', 't.tjid = j.tjid');
+  $query->fields('j', array('source_language', 'target_language'));
+  $result = $query->execute()->fetchAll();
+  $languages = array();
+
+  foreach ($result as $row) {
+    if (empty($languages[$row->source_language]) || !in_array($row->target_language, $languages[$row->source_language])) {
+      $languages[$row->source_language][] = $row->target_language;

If you add groupBy()/distinct() to the query then you don't need the condition in the foreach.

That or key by target language as well, then you don't need it either. But groupBy is probably the fastest option.

+++ b/translators/tmgmt_local/tmgmt_local.testundefined
@@ -165,4 +302,26 @@ class TMGMTLocalTestCase extends TMGMTBaseTestCase {
+  function dtestAllowAll() {

Test is still disabled, should not be the case.

I will fix and commit that myself once I find the time but feel free to update if you get to it before I do.

There should be an option in the translator settings to enable that.

Commited and pushed.

But I noticed this after I already pushed:

+++ b/translators/tmgmt_local/tmgmt_local.moduleundefined
@@ -508,6 +512,33 @@ function tmgmt_local_task_statuses() {
+  $query->fields('j', array('source_language', 'target_language'));
+  $query->groupBy('target_language');
+  $result = $query->execute()->fetchAll();
+  $languages = array();
+
+  foreach ($result as $row) {
+    if (empty($languages[$row->source_language]) || !in_array($row->target_language, $languages[$row->source_language])) {
+      $languages[$row->source_language][] = $row->target_language;

It needs to group on both target and source language, otherwise it will only return one record per target language.

And the if would then really be unecessary :)