Nice module. After switching the format of a field collection to a table, I got the following errors though:

Notice: Undefined index: view modes in field_view_mode_settings() (line 627 of C:\wamp\www\mysite\modules\field\field.module).
Warning: Invalid argument supplied for foreach() in field_view_mode_settings() (line 627 of C:\wamp\www\mysite\modules\field\field.module).

CommentFileSizeAuthor
#2 field-collection-table-1877218.patch1.03 KBlarowlan

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

This seems to relate to the update to field_collection to support revisions, prior to that there was no warning.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Needs review
StatusFileSize
new field-collection-table-1877218.patch1.03 KB

Patch fixes the issue, not sure what it breaks.
Basically to reproduce, enable field_collection, field_collection_table and workbench_moderation.
Create a new draft of a moderated node that has field collections on it, view the draft.

robcarr’s picture

robcarr
Primary language English
Location Perthshire, Scotland
commented

Patch worked for me. Haven't found any collateral damage.

+1 for RTBC - other please review

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
commented
Version: 7.x-1.x-dev » 7.x-1.0-beta1
Status: Needs review » Reviewed & tested by the community

++
Thanks. #2 works for me too.
I think this small patch should be added to module.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

I was not using workbench_moderation, so that is not really in the equation.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Applied cleanly to current checkout, but with offset of 34.

katannshaw’s picture

katannshaw commented

Patch #2 worked for me. Thanks larowlan!

presleyd’s picture

presleyd commented

#2 worked for me also.

lunk rat’s picture

lunk rat commented
Issue summary: View changes

Please commit #2.

siwinski’s picture

siwinski commented

#2 worked for me as well. Thanks!

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Not working for me.

joelstein’s picture

joelstein commented

#2 fixes the notices, thanks!

Yuri’s picture

Yuri commented

I tried to apply the patch. but it cannot be applied any more to the latest dev of Field Collection Table.

kevineinarsson’s picture

kevineinarsson commented
Status: Reviewed & tested by the community » Closed (fixed)

Patched dev, thanks guys.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.