Change notice: Improve Views UI text for the contextual links display setting

The text is shorter and it's indeed faster to read.

Add the moment in the patch it will show "Display contextual links: shown" and not like the above screenshot. So either we just use Contextual links, like the image suggests, or, if we go with Display contextual links, we should keep this to yes/no. We also need to change the form title.

Maybe like this? It keeps the 'Display contextual links' text change from the last patch.

I was going by what the label in the first patch had been changed to. For me, shown is a weird word, because they aren't really shown, not all the time anyway.

Ok, I don't mind, but then the label should just be 'Contextual links' and not 'Display contextual links'.

Mh it caused several problems in the past when we replaced booleans with it's opposites in the UI, maybe we should think about it a bit more.

If "shown" does not make sense (because they are displayed only on hover), then how about "enabled"/"disabled"?

So what about actually store whether to show admin links?

Ups

These changes are looking pretty good to me. I have changed the default option to TRUE so it matches the default behaviour from before, plus I think the most common setting will be to have contextual links. That should fix the test failure too.

I think it's better having the getter/setter and new variable instead of the old hide_admin_links one.

I'm fine with being RTBC for the fix in #14

Needs a reroll...

error: patch failed: core/modules/views/views_ui/views_ui.module:247
error: core/modules/views/views_ui/views_ui.module: patch does not apply

Rerolled

Thanks for rerolling

No longer applies. :( Once it does, happy to commit! Looks like a good change.

Also, eventually, this will need an upgrade path. Jess says we should make note of this somewhere. Maybe move this issue to the "Views D8 Upgrade" project post-commit.

Rerolled

Yeah, we'll need both a change notice and an upgrade path from this one, so I figure core -> views -> http://drupal.org/project/views_d8_upgrade ?

We could create a workflow which covers the change notice first and then it's moved to d8 upgrade.

Looks like webchick's got this one

#23: 1877376-23.patch queued for re-testing.

Committed and pushed to 8.x. Thanks!

Moving to the Views queue.

It works for me

For more information as to why this issue was moved to the Drupal core project, please see issue #3030347: Plan to clean process issue queue

Moving back to the contributed Views issue queue and closing as outdated per https://www.drupal.org/project/views/issues/3030347#comment-13023447