AFAICT the function action_views_form_substitutions (in core/modules/action/action.views.inc) has no purpose since the action module is using the standard tableselect javascript - see core/modules/action/lib/Drupal/action/Plugin/views/field/BulkForm.php. I think this code is left-overs from the VBO select all implementation in D7 that had custom JS and CSS code.

CommentFileSizeAuthor
#2 core-action-1877612.patch788 byteshansfn

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Fixed

We need this to make the select all box working, so I don't see a reason to remove it.

hansfn’s picture

hansfn commented
Status: Fixed » Active
StatusFileSize
new core-action-1877612.patch788 bytes

Thx for the quick reply, dawehner, but I think you are wrong. The code was needed before the action module started to use the standard tableselect javascript. I have attached a trivial patch so you can verify for yourself that select all still works after removing this function.

To give your more detail: In D7 VBO, the label function of the class views_bulk_operations_handler_field_operations returned "<!--views-bulk-operations-select-all-->" (when applicable). The action module never does this, and hence the substitutions in action_views_form_substitutions has no effect.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Version: 8.2.x-dev » 8.3.x-dev
Issue summary: View changes
Status: Active » Closed (works as designed)

This is no longer applicable AFAIT, Feel free to reopen