Follow up for #1869250-37: Various EntityNG and TypedData API improvements

Problem/Motivation

getOriginalEntity() slightly clashes with our current notion of $entity->original during saving/updating

Proposed resolution

Develop a "Plan B" in case we do not manage to kill the BC layer.

Remaining tasks

  • brainstorm a plan b.

User interface changes

None.

API changes

To be determined.

Original report by @sun

From: #1869250-37: Various EntityNG and TypedData API improvements

+++ b/core/lib/Drupal/Core/Entity/EntityInterface.php
@@ -190,4 +191,23 @@ public function isDefaultRevision($new_value = NULL);
+  public function getOriginalEntity();

This slightly clashes with our current notion of $entity->original during saving/updating, no?

However, if I get this right, then this BC layer is supposed to be removed anyway before release, so I guess the name clash doesn't matter for now.

That said, do we have a "Plan B" in case we do not manage to kill the BC layer before release? Should we perhaps create an issue for such a plan B, tagged with "revisit before release"?

Comments

fago’s picture

fago
Primary language German
Location Vienna
commented

Quoting myself from http://drupal.org/node/1869250#comment-6893050:

Nop, we don't have a plan B and imho we really shouldn't but focus on moving on. Having both in place is not only a DX nightmare, anything using BC is also slower. Let's make sure we convert everything! Issue: #1818580: [Meta] Convert all entity types to the new Entity Field API
I posted some thoughts on how we could speed up EntityNG adoption there: http://drupal.org/node/1818580#comment-6893030.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Postponed » Closed (won't fix)

OK, in that case, I think we can won't fix this issue, and we'll have to re-evaluate anyway nearby code freeze.

eclipsegc’s picture

eclipsegc commented

I'm following this now just in case it gets reopened, PLEASE, no plan B. We have got to get everything converted properly and I would 100% advocate holding up release until we do have it all converted.

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented
Issue summary: View changes
Issue tags: -revisit before beta

This function was renamed in #1877638: Rename getOriginalEntity() and remove duplicated functions from ConfigEntityBase then the BC layer was killed in #1983554: Remove BC-mode from EntityNG , no plan B needed so removing revisit tag.