Improvements:

  • Use #tree attribute to encapsulate the values of sub-fields.
  • Move value processing to the #element_validate callback so processing is done on the form submit only.
  • Support for #required attribute.
  • Avoid unnecessary processing of variables that are not used on some conditions.

Patch follows.

CommentFileSizeAuthor
#1 autocomplete_deluxe-1877692-1.patch7.66 KBdmitriy.trt

Comments

dmitriy.trt’s picture

dmitriy.trt commented
Status: Active » Needs review
StatusFileSize
new autocomplete_deluxe-1877692-1.patch7.66 KB

Patch for the latest git code at the moment.

I could try to make a step-by-step patches if it's really necessary and could help you to commit changes.

sepgil’s picture

sepgil commented
Status: Needs review » Needs work

Hey, today i committed the other issue with the #tree attribute. So one part of your patch is done. I think we should split the rest into seperate issues, so we can review them better.

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
Status: Needs work » Closed (outdated)