In function facetapi_theme() we should use 'variables' array key instead of 'arguments'.

CommentFileSizeAuthor
#4 facetapi-arguments-to-variables-1878998-4.patch1.74 KBcsg

Comments

cpliakas’s picture

cpliakas commented
Title: hoo_theme mistake » hook_theme() implementations use the D6 "arguments" key as opposed to the D7 "variables" key

Good catch! Bug confirmed.

cpliakas’s picture

cpliakas commented
Version: 7.x-1.2 » 7.x-1.x-dev

Bumping version to 7.x-1.x.

cpliakas’s picture

cpliakas commented
Issue tags: +low hanging fruit

Adding "low hanging fruit" tag.

csg’s picture

csg commented
Status: Active » Needs review
StatusFileSize
new facetapi-arguments-to-variables-1878998-4.patch1.74 KB

It sure was a low hanging fruit.

m1n0’s picture

m1n0 commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

The patch still applies nicely, marking as RTBC.

cpliakas’s picture

cpliakas commented
Status: Reviewed & tested by the community » Fixed

  • cpliakas committed 40236e6 on 7.x-1.x 
    Issue #1878998 by csg, m1n0: hook_theme() implementations use the D6 "...

  • cpliakas committed 41a55ca on 
    Issue #1878998 by csg, m1n0: hook_theme() implementations use the D6 "...

  • cpliakas committed 5a6b45b on 7.x-1.x authored by csg 
    Issue #1878998 by csg, m1n0: hook_theme() implementations use the D6 "...

  • cpliakas committed b842216 on authored by csg 
    Issue #1878998 by csg, m1n0: hook_theme() implementations use the D6 "...
cpliakas’s picture

cpliakas commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.