Once #1760270: Comment translation broken? is in and our dependencies have been updated (which might require a new release from us and ET), they should pass again. Patch coming in a second.

CommentFileSizeAuthor
#15 enable-comments-test-1879250-15.interdiff.txt700 bytesarla
#15 enable-comments-test-1879250-15.patch7.04 KBarla
#12 enable-comments-test-1879250-12.interdiff.txt733 bytesarla
#12 enable-comments-test-1879250-12.patch6.99 KBarla
#9 enable-comments-test-1879250-9.patch7.07 KBarla
#1 enable-comments-tests-1879250-1.patch1.45 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new enable-comments-tests-1879250-1.patch1.45 KB

Status: Needs review » Needs work

The last submitted patch, enable-comments-tests-1879250-1.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review

#1: enable-comments-tests-1879250-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, enable-comments-tests-1879250-1.patch, failed testing.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented 
+++ b/sources/entity/ui/tmgmt_entity_ui.testundefined
@@ -416,7 +415,7 @@ class TMGMTEntitySourceUITestCase extends TMGMTEntityTestCaseUtility {
+      'comment_body[und][0][value]' => $this->randomName(),

How can we translate records in the language "und"?
Shouldn't this be "en" (the source language) to even allow us use entity translation?

I consider this related to
#1917874: Add tests: Source language of tmgmt_job is always 'en'

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

No, that's how it is and not related to that issue. Comments initially have und and only change the language while saved.

This fails because of the old dependency, we need a new release so that the entity_translation dependency is updated so that the dependencies are updated and the new version is used.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review

#1: enable-comments-tests-1879250-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, enable-comments-tests-1879250-1.patch, failed testing.

arla’s picture

arla commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new enable-comments-test-1879250-9.patch7.07 KB

This should fix it for 8.x.

Status: Needs review » Needs work

The last submitted patch, 9: enable-comments-test-1879250-9.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented 
+++ b/sources/content/src/Tests/ContentEntitySourceUiTest.php
@@ -219,67 +220,59 @@ class ContentEntitySourceUiTest extends EntityTestBase {
     // Go to the translate tab.
-    $this->clickLink('edit');
-    $this->assertTrue(preg_match('|comment/(\d+)/edit$|', $this->getUrl(), $matches), 'Comment found');
-    $comment = comment_load($matches[1]);
+    $this->clickLink('Edit');
+    $this->assertUrl('comment/1/edit');
+    $comment = Comment::load(1);

We used this preg match thing to not hardcode ID's. For example, some systems have different auto increment behavior, and it would not be 1, but 2. Is there a specific reason that you had to change this?

arla’s picture

arla commented
Status: Needs work » Needs review
StatusFileSize
new enable-comments-test-1879250-12.patch6.99 KB
new enable-comments-test-1879250-12.interdiff.txt733 bytes

Aha, did not know. Just edited for simplicity. Reverting those lines.

Status: Needs review » Needs work

The last submitted patch, 12: enable-comments-test-1879250-12.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

comment_load() => Comment::load().

arla’s picture

arla commented
Status: Needs work » Needs review
StatusFileSize
new enable-comments-test-1879250-15.patch7.04 KB
new enable-comments-test-1879250-15.interdiff.txt700 bytes

Gah.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Needs work

Nice, committed, back to 7.x!

  • Berdir committed 86fe606 on 8.x-1.x authored by Arla 
    Issue #1879250 by Arla, Berdir: Re-enable comment entity source...