Here's another usability improvement to the forum. Rather than return no table when no containers or forums exist, a message is displayed inside the table telling the user that no containers or forums exist and how to create a new one.

CommentFileSizeAuthor
#6 forum_11.patch438 bytesSteve Dondley
#4 forum_10.patch0 bytesSteve Dondley
forum_patch.patch412 bytesSteve Dondley
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented

+1 for the functionality. -1 for the specific implementation. Other places in the code use em rather than strong. The colspan attribute should be used to stretch this row across the whole table.

The instructions on the second line could be a good idea, but should be hidden if the user does not have permissions to do that action. Do we want to update other places to do the same thing?

Steven’s picture

Steven CreditAttribution: Steven commented

Not to mention missing t()'s...

Dries’s picture

Dries CreditAttribution: Dries commented

Waiting for a new patch. Marking this 'active'.

Steve Dondley’s picture

Steve Dondley CreditAttribution: Steve Dondley commented
FileSize
forum_10.patch0 bytes

Revised patch attached. It addresses problems noted by others in my original patch. However, this patch revision does not address drumm's recommendation to hide the message from anauthorized users. Unless I'm mistaken, users without the permission to administer forums will receive an "Access denied" message and would not see the help message anyway.

Please correct me if I'm wrong on this.

Steve Dondley’s picture

Steve Dondley CreditAttribution: Steve Dondley commented

Patch showed up as zero bytes. I think my Linux box crashed in the middle of tranferring the file. I'll reupload when I get it back up.

Steve Dondley’s picture

Steve Dondley CreditAttribution: Steve Dondley commented
FileSize
forum_11.patch438 bytes

OK, let's try uploding this patch again. On the old clunker machine I have, even Debian crashes from time to time.

Steve Dondley’s picture

Steve Dondley CreditAttribution: Steve Dondley commented

new patch uploaded

Steven’s picture

Steven CreditAttribution: Steven commented

I commited a modified patch:
- The br doesn't belong there. It is layout, not semantics.
- You should avoid telling people to click somewhere. Just provide a link directly.

Before

There are no existing containers or forums. Click on the
"add container" or "add forum" tab to create one.

After

There are no existing containers or forums. You may add some on the add container or add forum pages.

Anonymous’s picture

(not verified) CreditAttribution: commented