Simple Entities

Hi kerasai,

I don't see any commits. Also, I think you should have more detail about this module on your project page.

Interesting project. As a developer this looks like a very handy tool to have around.

run the automated test on http://ventral.org/pareview/httpgitdrupalorgsandboxbmoresafety201879546git
no errors or warnings found

Installed the example module and run the coder module check. One thing came up for the example module:

se_example.module

Line 187: Potential problem: confirm_form() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.
return confirm_form($form, $question, $path);

When trying to use the form created by the example module, to add a new entity there was a PDO exception when trying to add a second item:

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1' for key 'uid': INSERT INTO {se_example} (uid, created, modified, text) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3); Array ( [:db_insert_placeholder_0] => 1 [:db_insert_placeholder_1] => 1357280668 [:db_insert_placeholder_2] => 1357280668 [:db_insert_placeholder_3] => test 3 ) in drupal_write_record() (line 7106 of /opt/drupal/notificare/drupal-7.18/includes/common.inc).

You may want to add some more instructions and/or examples in the README, on practical use.

Right, sorry didn't know that. The idea of this module is really useful indeed. I tried your module, as mention in jooplaan's review, there is an error when added a second record.

I think there can be a lot more room to improve this module. I know this is just example module, for I guess you can add more the demo nicer code.
I see there a quit a few of code need to hardcode the path, i.e.
function se_example_form_delete(&$form, &$form_state) {
$form_state['redirect'] = "se-example/{$form_state['storage']['se']->sid}/delete";
}

I think it would be nice to have a piece of code to get the path maybe? or a const? i.e.
function se_example_get_path() {
// Directly from the schema
$schema = se_example_schema();
return str_replace('_', '-', array_shift(array_keys($schema)));
// Or simply return a path
return 'se-example';
}

I think it would be nice to add a pager to the listing page as well.

Cheers!

I've also worked with entities a lot and always used the Entity API module as base for my entity crud implementations. In which functionality differentiates your module from the Entity API module? After a manual review of your code, it is a very limited version of it and can't see any usecases yet for your module where the Entity API lacks functionality.
Maybe you can clarify this a bit more in the description of your module what the difference is and when to use your module instead of the Entity API.

I tend to agree with robinvdvleuten. While I do see the value in having this in your toolkit, I don't know that a Drupal module is really appropriate here being that Entity API module already does much of what you're offering here.

See Entity API and ECK modules.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

Adjusted the repository URL to use HTTPS and that it would not require authentications.